Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow checking minimal dependency versions #77

Open
Marcono1234 opened this issue Jul 7, 2024 · 1 comment
Open

Add GitHub workflow checking minimal dependency versions #77

Marcono1234 opened this issue Jul 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Marcono1234
Copy link
Owner

Problem solved by the enhancement

By accident Struson could depend on a future introduced by a version of a dependency newer than specified in Cargo.toml; users of Struson could then encounter build issues if Cargo's dependency resolution picks the older version (e.g. due to restrictions from other dependencies).

Enhancement description

Consider using Cargo's direct-minimal-versions or https://crates.io/crates/cargo-minimal-versions (or similar).

Alternatives / workarounds

  • Include this as task in Makefile.toml instead of just in a GitHub workflow
    (maybe not worth it because it causes too much overhead for every build)
  • Do nothing and hope / assume the problem described above is not common enough
@Marcono1234 Marcono1234 added the enhancement New feature or request label Jul 7, 2024
@Marcono1234
Copy link
Owner Author

Marcono1234 commented Jul 16, 2024

Maybe this is not that important, or needed at all, because Dependabot keeps the versions up to date and makes sure Cargo.toml and Cargo.lock are in sync.
Might mainly be an issue when intentionally staying on older minimum dependency version, but the version in Cargo.lock is updated to a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant