- New code follows the Google Java Style Guide
This is automatically checked bymvn verify
, but can also be checked on its own usingmvn spotless:check
.
Style violations can be fixed usingmvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes. - If necessary, new public API validates arguments, for example rejects
null
- New public API has Javadoc
- Javadoc uses
@since $next-version$
($next-version$
is a special placeholder which is automatically replaced during release)
- Javadoc uses
- If necessary, new unit tests have been added
- Assertions in unit tests use Truth, see existing tests
- No JUnit 3 features are used (such as extending class
TestCase
) - If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
-
mvn clean verify javadoc:jar
passes without errors