Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit interactions in maps without layers #503

Open
Malvoz opened this issue Jul 31, 2021 · 2 comments
Open

Limit interactions in maps without layers #503

Malvoz opened this issue Jul 31, 2021 · 2 comments

Comments

@Malvoz
Copy link
Member

Malvoz commented Jul 31, 2021

As I was reading "Maps have one or more layers" in @prushforth's <layer-> doc draft I realized I didn't know what would happen in maps that don't have any layers (or layers without src and no inline content).

After inspecting how browsers (Chrome and Firefox) treat <video></video> I believe we should try to limit interactions with the map element as much as possible if it has no layers. For example by:

  1. Disabling controls (aria-hidden="true" and tabindex="-1" on each control)
  2. Disabling the context menu (and keyboard shortcuts)
  3. Hide the predefined attribution
@Malvoz
Copy link
Member Author

Malvoz commented Nov 23, 2021

  1. Disabling the context menu (and keyboard shortcuts)

The context menu should most likely not be disabled, especially if that's the only way for users restore removed layers (#460).

@prushforth
Copy link
Member

So far, I don't see how we can get back a deleted node or restore the checked attribute states of the DOM. Unless the browser is considering a new DOM history API that allows you to capture DOM states not just the page URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants