Skip to content

Commit 52814a9

Browse files
committed
Updated documentation for extra item removal
1 parent 2d9ec84 commit 52814a9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,9 @@ def adjust_filler_items(self, item_pool, traps):
383383
item_pool.append(extra_item)
384384
elif extras < 0:
385385
logging.warning(f"{self.game} has more items than locations. {abs(extras)} non-progression items will be removed at random.")
386+
# Filler is only assigned if the item doesn't have any other tags, so it only has to be covered by itself.
387+
# Skip Balancing is also not covered due to how it's only supported when paired with Progression.
388+
# As a result, these cover every possible combination can be removed.
386389
fillers = [item for item in item_pool if item.classification == ItemClassification.filler]
387390
traps = [item for item in item_pool if item.classification == ItemClassification.trap]
388391
useful = [item for item in item_pool if item.classification == ItemClassification.useful]
@@ -403,7 +406,6 @@ def adjust_filler_items(self, item_pool, traps):
403406
popped = traps.pop()
404407
elif useful:
405408
popped = useful.pop()
406-
# Not sure if Useful + Trap should go before or after Useful.
407409
elif useful_traps:
408410
popped = useful_traps.pop()
409411
else:

0 commit comments

Comments
 (0)