Skip to content

Commit 1f41d5a

Browse files
authored
DataValidation: Bug in inaccessible non-starting region check (#160)
* fix broken unreachable starting regions * prevent starting false from matching as starting regions being in use
1 parent 41541e9 commit 1f41d5a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/DataValidation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,12 +423,12 @@ def checkForLocationsBeingInvalidJSON():
423423

424424
@staticmethod
425425
def checkForNonStartingRegionsThatAreUnreachable():
426-
using_starting_regions = len([region for region in DataValidation.region_table if "starting" in DataValidation.region_table[region] and not DataValidation.region_table[region]["starting"]]) > 0
426+
using_starting_regions = len([region for region in DataValidation.region_table if DataValidation.region_table[region].get("starting")]) > 0
427427

428428
if not using_starting_regions:
429429
return
430430

431-
nonstarting_regions = [region for region in DataValidation.region_table if "starting" in DataValidation.region_table[region] and not DataValidation.region_table[region]["starting"]]
431+
nonstarting_regions = [region for region in DataValidation.region_table if not DataValidation.region_table[region].get("starting")]
432432

433433
for nonstarter in nonstarting_regions:
434434
regions_that_connect_to = [region for region in DataValidation.region_table if "connects_to" in DataValidation.region_table[region] and nonstarter in DataValidation.region_table[region]["connects_to"]]

0 commit comments

Comments
 (0)