Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contribution Guidelines and Issue/PR Templates #48

Merged
merged 8 commits into from
May 4, 2022
Merged

Add Contribution Guidelines and Issue/PR Templates #48

merged 8 commits into from
May 4, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Mar 28, 2022 •
edited
Loading

This PR adds contribution guidelines and issue/PR templates.

@bhgomes bhgomes added this to the Version 0 milestone Mar 28, 2022
@bhgomes bhgomes self-assigned this Mar 28, 2022
@bhgomes bhgomes linked an issue Mar 28, 2022 that may be closed by this pull request
Add repository maintenance documentation #20
Closed
3 tasks
@bhgomes bhgomes changed the title Add Code Style and Contribution Guidelines Add Contribution Guidelines and Issue/PR Templates Mar 28, 2022
@bhgomes bhgomes added the A-documentation Area: Improvements or additions to documentation label Mar 28, 2022
@bhgomes bhgomes marked this pull request as ready for review May 2, 2022 22:39
Kevingislason
Kevingislason approved these changes May 4, 2022
View reviewed changes
Copy link

@Kevingislason Kevingislason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to add a PR template? I see only an empty file.

Otherwise, looks good to me.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@bhgomes
Copy link
Contributor Author

bhgomes commented May 4, 2022

Did you intend to add a PR template? I see only an empty file.

Otherwise, looks good to me.

I left it blank for now, just want to merge what we have already. I'll spend more time on this in the next production cycle.

@bhgomes bhgomes merged commit ec4470b into main May 4, 2022
@bhgomes bhgomes deleted the feat/contributing branch May 4, 2022 15:03
BoyuanFeng pushed a commit that referenced this pull request Jun 2, 2022
@bhgomes
Add Contribution Guidelines and Issue/PR Templates (#48)
c3cbabc 
* feat: start adding the CONTRIBUTING.md file
* feat: start adding templates
* feat: add some documentation guidelines
* feat: add instructions for traits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevingislason Kevingislason Kevingislason approved these changes

@GhostOfGauss GhostOfGauss Awaiting requested review from GhostOfGauss

@BoyuanFeng BoyuanFeng Awaiting requested review from BoyuanFeng

Assignees

@bhgomes bhgomes

Labels
A-documentation Area: Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add repository maintenance documentation
2 participants
@bhgomes @Kevingislason