-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce cost of signer key-search algorithm with pre-compute table #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
added
changelog:fixed
Changelog: add these changes to the `fixed` section of the changelog
norelease
labels
Jun 22, 2022
BoyuanFeng
suggested changes
Jun 24, 2022
ghost
approved these changes
Jun 27, 2022
Kevingislason
approved these changes
Jun 27, 2022
BoyuanFeng
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon H. Gomes bhgomes@pm.me
Before this PR, the signer key-search algorithm would re-compute every viewing key within the search range on every insertion of a UTXO. Now, we use a dynamic program that replaces the viewing key computation with a lookup if the key has already been computed. To prevent run-away growth of this table we have a max capacity set to
16
times theGAP_LIMIT
(currently set to20
), a very unlikely limit to be reached except for implementation errors or purposeful memory attacks.This PR also adds some utility functions for B-Trees.
Focus Files:
manta-accounting/src/wallet/signer.rs
manta-accounting/src/key.rs
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.