Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync protocol optimizations #348

Closed
SupremoUGH opened this issue May 19, 2023 · 1 comment
Closed

Sync protocol optimizations #348

SupremoUGH opened this issue May 19, 2023 · 1 comment

Comments

@SupremoUGH
Copy link
Contributor

SupremoUGH commented May 19, 2023 •
edited
Loading

A more interesting question is: can we just keep the Nullifiers that belong to us? I think we can by using the OutgoingNotes but I didn't want to overcomplicate this PR. That's a further optimization for when we are sure the bug is fixed.

Originally posted by @SupremoUGH in #347 (comment)

do you mind writing out the logic of why we mutate the assets/nullifiers here once and then at the end as well, to make it easier for new people to get into this part of the code.
Originally posted by @ghzlatarev in #347 (comment)
@SupremoUGH SupremoUGH mentioned this issue May 19, 2023
Merged
4 tasks
@SupremoUGH
Copy link
Contributor Author

Closed here: #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SupremoUGH