Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tx-limit feature to limit to_private transfer #878

Open
zqhxuyuan opened this issue Nov 2, 2022 · 1 comment · May be fixed by #879
Open

add tx-limit feature to limit to_private transfer #878

zqhxuyuan opened this issue Nov 2, 2022 · 1 comment · May be fixed by #879
Assignees
Labels
A-manta-pay Area: Issues and PRs related to the MantaPay Pallet A-security Area: Issues and PRs related to Security C-enhancement Category: An issue proposing an enhancement or a PR with one P-released Product: already released product related features
Milestone

Comments

@zqhxuyuan
Copy link
Contributor

zqhxuyuan commented Nov 2, 2022

  • Choice1: add a new pallet to set asset config
    - Choice2: asset limit is kind of asset metadata, we can add a new field to asset-metadata
  • intergation with pallet-manta-pay
    • pallet-manta-pay use FungibleLedger trait, add another ensure_valid(asset_id, amount) to make sure tx is valid
      • amount is allowed when asset_id has limitation
      • or asset_id has no limitation.
    • add another trait and let pallet-manta-pay directly use TransactionLimit as implementation
@zqhxuyuan zqhxuyuan changed the title add tx-limit feature to limit private transfer on pallet-manta-pay add tx-limit feature to limit to_private transfer Nov 2, 2022
@zqhxuyuan zqhxuyuan linked a pull request Nov 2, 2022 that will close this issue
6 tasks
@Garandor
Copy link
Contributor

Garandor commented Nov 4, 2022

    • Choice2: asset limit is kind of asset metadata, we can add a new field to asset-metadata

Why did you get rid of Choice 2? I don't see a reason why it wouldnt work. We can adjust it using the update_asset_metadata extrinsic, but we'd have to add it to #814 before the RT goes live.

@ghzlatarev ghzlatarev added this to the v4.0.0 milestone Nov 21, 2022
@ghzlatarev ghzlatarev modified the milestones: v4.0.0, v4.0.1 Dec 9, 2022
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta-pay Area: Issues and PRs related to the MantaPay Pallet P-released Product: already released product related features A-security Area: Issues and PRs related to Security labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta-pay Area: Issues and PRs related to the MantaPay Pallet A-security Area: Issues and PRs related to Security C-enhancement Category: An issue proposing an enhancement or a PR with one P-released Product: already released product related features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants