Skip to content

Rename manim.typing.Image type aliases to PixelArray to avoid conflict with PIL.Image #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2024
Merged

Rename manim.typing.Image type aliases to PixelArray to avoid conflict with PIL.Image #3851

merged 3 commits into from
Jul 12, 2024

Conversation

chopan050
Copy link
Contributor

Easy review! We needed to make that change in the experimental branch because we had some conflicts, and I thought, why not implement it in main as well?

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@chopan050 chopan050 added documentation Improvements or additions to documentation pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! typehints For adding/discussing typehints labels Jul 12, 2024
JasonGrace2282
JasonGrace2282 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JasonGrace2282 JasonGrace2282 enabled auto-merge (squash) July 12, 2024 13:52
@chopan050 chopan050 changed the title Rename typing.Image type aliases to PixelArray to avoid conflict with PIL.Image Rename manim.typing.Image type aliases to PixelArray to avoid conflict with PIL.Image Jul 12, 2024
@JasonGrace2282 JasonGrace2282 merged commit 67f95db into ManimCommunity:main Jul 12, 2024
18 of 19 checks passed
@chopan050 chopan050 deleted the rename-image-to-pixel-array branch July 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGrace2282 JasonGrace2282 JasonGrace2282 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! typehints For adding/discussing typehints
Projects
Dev Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chopan050 @JasonGrace2282