Replace last os.path occurrencies by pathlib
#3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves [last comment](ManimCommunity#485 (comment)) of ManimCommunity#485. Removes one line of dead code.
|
Hi, I saw that pre-commit is having with files I did not touch. So, I investigated to pinpoint the source of the problem and when it was introduced. It comes from a recent PR merged in flake8-comprensions, the fixes this issue. I found it through this issue. An issue should be opened here to remove lists in any/all. I'll try to do it when I have some time if it is not done before. |
behackl
approved these changes
May 2, 2023
abul4fia
pushed a commit
to abul4fia/manim
that referenced
this pull request
May 10, 2023
This resolves [last comment](ManimCommunity#485 (comment)) of ManimCommunity#485. Removes one line of dead code. Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
behackl
added a commit
that referenced
this pull request
Jun 20, 2023
* Small fix in the code of ArcBrace Avoiding the creation of an Arc object at import time * Replace last `os.path` occurrencies by `pathlib` (#3224) This resolves [last comment](#485 (comment)) of #485. Removes one line of dead code. Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at> * Made docbuild errors easier to debug + fixed error from changed exception class (#3229) * Make errors during docbuild somewhat easier to debug * fix an issue with docbuild under py3.10+ * Make set_resampling_algorithm() return self --------- Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at> Co-authored-by: Adrien ANTON LUDWIG <42720099+Adrien-ANTON-LUDWIG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Replace the last 2
os.pathoccurrencies bypathlib.Removes one line of dead code.
Motivation and Explanation: Why and how do your changes improve the library?
This resolves last comment of #485.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist