Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency Key #620

Open
beerbohmdo opened this issue Dec 15, 2023 · 3 comments
Open

Idempotency Key #620

beerbohmdo opened this issue Dec 15, 2023 · 3 comments

Comments

@beerbohmdo
Copy link

Is the Idempotency Key feature disabled on the sandbox or does it just not work?

I tried it by creating the same user twice (same key). But it succeeds and gives me two users with different ids.

The unittests fails also:
https://github.com/Mangopay/mangopay2-php-sdk/actions/runs/7125884722/job/19402676990#step:6:152

And this test method is poorly implemented:
https://github.com/Mangopay/mangopay2-php-sdk/blob/master/tests/Cases/IdempotencyTest.php#L35

@renanbr
Copy link

renanbr commented Dec 19, 2023

Same issue here.

We tried creating the same PayIn on the sandbox.

I have no idea if in production this is working.

ps: We don't have this feature implemented in production.

@beerbohmdo
Copy link
Author

We generate idempotency keys in production, but I don't know if they work.(I never directly tested that).

I only tested it now, because I wanted to add a auto retry mechanic ... But as we speak about 1-3 failed requests in the last year, I should skip this idea. That can only go wrong, even with working idempotency keys.

@fredericdelordm
Copy link
Contributor

Hello @beerbohmdo,

We are looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants