Textual Summary fixes and improvements #30
Conversation
|
Checked commits martinpovolny/react-ui-components@1594b0a~...bd19711 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| ); | ||
| }; | ||
|
|
||
| const renderValue = function renderValue(value, onClick) { |
There was a problem hiding this comment.
Just a small nitpick. You don't have to write const functionName = function functionName(...), you can replace it with const functionName = (...) => {}. The function definition after the = is useless. I have noticed that you are using this very often.
There was a problem hiding this comment.
Or you can write just function renderValue(value, onClick) { which is probably the best, if it's not just simple function with one liner as return otherwise go ahead and use const functionName = (...) => ({some: object})
|
Seems to be working just fine. Bool values are now visible :) |
| ); | ||
| }; | ||
|
|
||
| const renderValue = function renderValue(value, onClick) { |
There was a problem hiding this comment.
Or you can write just function renderValue(value, onClick) { which is probably the best, if it's not just simple function with one liner as return otherwise go ahead and use const functionName = (...) => ({some: object})
|
@karelhala, @himdel : can you, please, merge this one? @karelhala : will you, please, also release a new version with this? |
4 participants
Number of textual summary fixes and improvements: