Skip to content

Convert user form to React #8916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Convert user form to React #8916

wants to merge 2 commits into from

Conversation

@GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Sep 11, 2023 •
edited
Loading

Fixes: #6903 and #6904

Converted user form to React and added Cypress tests for the form.

Before:

Edit Admin User Form:
AdminUserBefore
Add User Form:
AddUserBefore
Edit User Form:
EditUserBefore
Copy User Form:
CopyUserBefore

After:

Edit Admin User Form:
AdminUserAfter
Add User Form:
AddUserAfter
Edit User Form:
EditUserAfter
Copy User Form:
CopyUserAfter

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner September 11, 2023 13:11
@miq-bot miq-bot added the wip label Sep 11, 2023
jeffibm
jeffibm reviewed Sep 11, 2023
View reviewed changes
jeffibm
jeffibm reviewed Sep 11, 2023
View reviewed changes
jeffibm
jeffibm reviewed Sep 11, 2023
View reviewed changes
@jeffibm jeffibm mentioned this pull request Sep 12, 2023
Closed
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 2 times, most recently from a959e72 to ffd13db Compare October 2, 2023 19:51
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 5 times, most recently from 444bd81 to 0b91982 Compare October 6, 2023 15:54
@GilbertCherrie GilbertCherrie mentioned this pull request Oct 24, 2023
Open
15 tasks
@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot miq-bot added the stale label Feb 19, 2024
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 3 times, most recently from f181f47 to 55e116c Compare May 6, 2024 16:43
@kbrock
Copy link
Member

kbrock commented May 9, 2024

as mentioned elsewhere, passing attributes=miq_groups will bring back the groups

@GilbertCherrie GilbertCherrie changed the title [WIP] Convert user form to React Convert user form to React May 27, 2024
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 3 times, most recently from d34575a to 63b757b Compare May 27, 2024 20:13
elsamaryv
elsamaryv reviewed Mar 27, 2025
View reviewed changes
elsamaryv
elsamaryv reviewed Mar 27, 2025
View reviewed changes
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2025

This pull request is not mergeable. Please rebase and repush.

@kbrock
Copy link
Member

kbrock commented Oct 27, 2025

Yay. can @elsamaryv merge, or do you need someone else to pull the trigger?

@GilbertCherrie
Copy link
Member Author

GilbertCherrie commented Oct 27, 2025

@kbrock I don't think Elsa has merge rights, but also although this pr should be good I was hoping @asirvadAbrahamVarghese can fix the cypress specs first before merging

@asirvadAbrahamVarghese
Copy link
Contributor

asirvadAbrahamVarghese commented Nov 3, 2025

Let’s try this out: GilbertCherrie#1

@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 2 times, most recently from cd3a66e to 2a03fb0 Compare November 5, 2025 14:24
@asirvadAbrahamVarghese asirvadAbrahamVarghese mentioned this pull request Nov 6, 2025
Merged
@asirvadAbrahamVarghese
Copy link
Contributor

asirvadAbrahamVarghese commented Nov 6, 2025

Regarding the Cypress failures, we’re currently seeing two main causes:

  1. Due to the session write issue
image

PR: #9533

  1. selectAccordionItem command not finding nodes because the list is still loading
image

PR: #9713

Once both PRs are merged, lets re-run the test to confirm if this resolves the failures

@asirvadAbrahamVarghese asirvadAbrahamVarghese mentioned this pull request Nov 12, 2025
Open
@jrafanie
Copy link
Member

jrafanie commented Nov 12, 2025

Rebased this PR to pull in the sporadic test failures fixed in #9713. We can address #9533 separately.

@GilbertCherrie @jrafanie
Refactor users form cypress test
0071f31 
Co-authored-by: asirvadAbrahamVarghese <Asirvad.Abraham.Varghese@ibm.com>

* Rebase to master and fix suggestions
* Fix cypress specs
@jrafanie jrafanie closed this Nov 12, 2025
@jrafanie jrafanie reopened this Nov 12, 2025
jrafanie
jrafanie reviewed Nov 13, 2025
View reviewed changes
cypress/e2e/ui/Settings/Application-Settings/users.cy.js
});

afterEach(() => {
cy.appDbState('restore');
Copy link
Member

@jrafanie jrafanie Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the last remaining sporadic failures, other than the API version of the "undefined method downcase for nil" error caused by API requests overwriting session data used by UI requests, is that the prior navigation appears to NOT wait until the ajax report data is completed.

[----] I, [2025-11-13T11:46:07.004931#58401:f78a0]  INFO -- development: Started POST "/ops/accordion_select?id=rbac_accord" for 127.0.0.1 at 2025-11-13 11:46:07 -0500
[----] I, [2025-11-13T11:46:07.016137#58401:f78a0]  INFO -- development: Completed 200 OK in 9ms (Views: 0.1ms | ActiveRecord: 3.3ms (10 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:07.461390#58401:f7904]  INFO -- development: Started POST "/ops/tree_select?id=xx-u&text=Users" for 127.0.0.1 at 2025-11-13 11:46:07 -0500
[----] I, [2025-11-13T11:46:07.470827#58401:f7904]  INFO -- development: Completed 200 OK in 7ms (Views: 0.3ms | ActiveRecord: 1.7ms (6 queries, 0 cached) | GC: 0.6ms)
[----] I, [2025-11-13T11:46:07.492197#58401:f7904]  INFO -- development: Started POST "/ops/report_data" for 127.0.0.1 at 2025-11-13 11:46:07 -0500
[----] I, [2025-11-13T11:46:07.505602#58401:f7904]  INFO -- development: Completed 200 OK in 11ms (Views: 0.1ms | ActiveRecord: 2.3ms (15 queries, 7 cached) | GC: 0.7ms)
[----] I, [2025-11-13T11:46:07.735820#58401:ef830]  INFO -- development: Started POST "/ops/x_button?pressed=rbac_user_add" for 127.0.0.1 at 2025-11-13 11:46:07 -0500
[----] I, [2025-11-13T11:46:07.743649#58401:ef830]  INFO -- development: Completed 200 OK in 6ms (Views: 0.2ms | ActiveRecord: 1.6ms (5 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:07.767126#58401:ef830]  INFO -- development: Started GET "/api/groups?&expand=resources" for 127.0.0.1 at 2025-11-13 11:46:07 -0500
[----] I, [2025-11-13T11:46:07.784709#58401:ef830]  INFO -- development: Completed 200 OK in 15ms (Views: 0.0ms | ActiveRecord: 2.3ms (10 queries, 0 cached) | GC: 2.7ms)
[----] I, [2025-11-13T11:46:11.422267#58401:d598]  INFO -- development: Started POST "/api/users" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] I, [2025-11-13T11:46:11.454612#58401:d598]  INFO -- development: Completed 200 OK in 30ms (Views: 0.0ms | ActiveRecord: 19.0ms (13 queries, 1 cached) | GC: 0.8ms)
[----] I, [2025-11-13T11:46:11.560890#58401:d598]  INFO -- development: Started GET "/ops/" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] I, [2025-11-13T11:46:11.566759#58401:d598]  INFO -- development: Completed 302 Found in 4ms (ActiveRecord: 0.9ms (5 queries, 0 cached) | GC: 0.2ms)
[----] I, [2025-11-13T11:46:11.572127#58401:d598]  INFO -- development: Started GET "/ops/explorer" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] I, [2025-11-13T11:46:11.609155#58401:d598]  INFO -- development: Completed 200 OK in 35ms (Views: 17.0ms | ActiveRecord: 6.6ms (21 queries, 2 cached) | GC: 1.7ms)
[----] I, [2025-11-13T11:46:11.797388#58401:d598]  INFO -- development: Started GET "/ws/notifications" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] I, [2025-11-13T11:46:11.799345#58401:d598]  INFO -- development: Started GET "/ws/notifications" [WebSocket] for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] I, [2025-11-13T11:46:11.802006#58401:f7990]  INFO -- development: Started GET "/api/notifications?expand=resources&attributes=details&sort_by=id&sort_order=desc&limit=100" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] I, [2025-11-13T11:46:11.813063#58401:f7990]  INFO -- development: Completed 200 OK in 8ms (Views: 0.0ms | ActiveRecord: 2.2ms (9 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:11.914043#58401:f7990]  INFO -- development: Started POST "/__e2e__/command" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
[----] D, [2025-11-13T11:46:11.916749#58401:f7990] DEBUG -- development: [Cypress] Running db_state restore
[----] I, [2025-11-13T11:46:11.916802#58401:f7990]  INFO -- development: [Cypress] DatabaseCleaner restoring
### ^^^ restore started
[----] I, [2025-11-13T11:46:11.940843#58401:f7904]  INFO -- development: Started POST "/ops/report_data" for 127.0.0.1 at 2025-11-13 11:46:11 -0500
### ^^^ likely an ajax request comes in late
[----] I, [2025-11-13T11:46:11.958555#58401:f7904]  INFO -- development: Completed 200 OK in 15ms (Views: 0.1ms | ActiveRecord: 3.5ms (17 queries, 7 cached) | GC: 0.3ms)
[----] D, [2025-11-13T11:46:12.175919#58401:f7990] DEBUG -- development: output: [null]
### ^^^ restore finished

Copy link
Member

@jrafanie jrafanie Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another example, after rbac_user_add:

[----] I, [2025-11-13T11:46:50.460788#58401:f7990]  INFO -- development: Started POST "/ops/x_button?pressed=rbac_user_add" for 127.0.0.1 at 2025-11-13 11:46:50 -0500
[----] I, [2025-11-13T11:46:50.470693#58401:f7990]  INFO -- development: Completed 200 OK in 7ms (Views: 0.1ms | ActiveRecord: 1.9ms (5 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:50.516137#58401:f7990]  INFO -- development: Started GET "/api/groups?&expand=resources" for 127.0.0.1 at 2025-11-13 11:46:50 -0500
[----] I, [2025-11-13T11:46:50.537965#58401:f7990]  INFO -- development: Completed 200 OK in 19ms (Views: 0.0ms | ActiveRecord: 7.2ms (10 queries, 0 cached) | GC: 0.9ms)
[----] I, [2025-11-13T11:46:54.993852#58401:f78a0]  INFO -- development: Started POST "/api/users" for 127.0.0.1 at 2025-11-13 11:46:54 -0500
[----] I, [2025-11-13T11:46:55.010451#58401:f78a0]  INFO -- development: Completed 200 OK in 14ms (Views: 0.0ms | ActiveRecord: 4.0ms (13 queries, 1 cached) | GC: 0.5ms)
[----] I, [2025-11-13T11:46:55.194157#58401:f78a0]  INFO -- development: Started GET "/ops/" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.202310#58401:f78a0]  INFO -- development: Completed 302 Found in 5ms (ActiveRecord: 1.0ms (5 queries, 0 cached) | GC: 0.2ms)
[----] I, [2025-11-13T11:46:55.207715#58401:f78a0]  INFO -- development: Started GET "/ops/explorer" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.247468#58401:f78a0]  INFO -- development: Completed 200 OK in 37ms (Views: 15.6ms | ActiveRecord: 9.6ms (21 queries, 2 cached) | GC: 1.8ms)
[----] I, [2025-11-13T11:46:55.527006#58401:f7904]  INFO -- development: Started GET "/ws/notifications" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.528850#58401:f7904]  INFO -- development: Started GET "/ws/notifications" [WebSocket] for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.529619#58401:d598]  INFO -- development: Started GET "/api/notifications?expand=resources&attributes=details&sort_by=id&sort_order=desc&limit=100" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.541627#58401:d598]  INFO -- development: Completed 200 OK in 8ms (Views: 0.0ms | ActiveRecord: 2.1ms (9 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:55.647140#58401:d598]  INFO -- development: Started POST "/__e2e__/command" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] D, [2025-11-13T11:46:55.649438#58401:d598] DEBUG -- development: [Cypress] Running db_state restore
[----] I, [2025-11-13T11:46:55.649470#58401:d598]  INFO -- development: [Cypress] DatabaseCleaner restoring
[----] I, [2025-11-13T11:46:55.682052#58401:ef830]  INFO -- development: Started POST "/ops/report_data" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
### ^^^ Another request comes in while database cleaner is restoring

Copy link
Member

@jrafanie jrafanie Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another a few steps after rbac_user_add:

[----] I, [2025-11-13T11:46:00.874134#58401:ef830]  INFO -- development: Started POST "/ops/x_button?pressed=rbac_user_add" for 127.0.0.1 at 2025-11-13 11:46:00 -0500
[----] I, [2025-11-13T11:46:00.888017#58401:ef830]  INFO -- development: Completed 200 OK in 12ms (Views: 0.1ms | ActiveRecord: 3.8ms (5 queries, 0 cached) | GC: 0.1ms)
[----] I, [2025-11-13T11:46:00.899298#58401:ef830]  INFO -- development: Started GET "/api/groups?&expand=resources" for 127.0.0.1 at 2025-11-13 11:46:00 -0500
[----] I, [2025-11-13T11:46:00.917305#58401:ef830]  INFO -- development: Completed 200 OK in 16ms (Views: 0.2ms | ActiveRecord: 2.4ms (10 queries, 0 cached) | GC: 0.4ms)
[----] I, [2025-11-13T11:46:04.357093#58401:d598]  INFO -- development: Started POST "/api/users" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.394063#58401:d598]  INFO -- development: Completed 200 OK in 34ms (Views: 2.6ms | ActiveRecord: 7.9ms (13 queries, 1 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:04.483768#58401:d598]  INFO -- development: Started GET "/ops/" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.490381#58401:d598]  INFO -- development: Completed 302 Found in 4ms (ActiveRecord: 1.0ms (5 queries, 0 cached) | GC: 0.1ms)
[----] I, [2025-11-13T11:46:04.496137#58401:d598]  INFO -- development: Started GET "/ops/explorer" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.569298#58401:d598]  INFO -- development: Completed 200 OK in 71ms (Views: 31.2ms | ActiveRecord: 23.0ms (21 queries, 2 cached) | GC: 0.8ms)
[----] I, [2025-11-13T11:46:04.744412#58401:d598]  INFO -- development: Started GET "/ws/notifications" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.746594#58401:d598]  INFO -- development: Started GET "/ws/notifications" [WebSocket] for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.748616#58401:f7904]  INFO -- development: Started GET "/api/notifications?expand=resources&attributes=details&sort_by=id&sort_order=desc&limit=100" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.760454#58401:f7904]  INFO -- development: Completed 200 OK in 7ms (Views: 0.0ms | ActiveRecord: 1.8ms (9 queries, 0 cached) | GC: 0.0ms)
[----] I, [2025-11-13T11:46:04.813573#58401:f7904]  INFO -- development: Started POST "/__e2e__/command" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] D, [2025-11-13T11:46:04.816051#58401:f7904] DEBUG -- development: [Cypress] Running db_state restore
[----] I, [2025-11-13T11:46:04.816074#58401:f7904]  INFO -- development: [Cypress] DatabaseCleaner restoring
[----] I, [2025-11-13T11:46:04.831803#58401:f7990]  INFO -- development: Started POST "/ops/report_data" for 127.0.0.1 at 2025-11-13 11:46:04 -0500
[----] I, [2025-11-13T11:46:04.847168#58401:f7990]  INFO -- development: Completed 200 OK in 12ms (Views: 0.1ms | ActiveRecord: 2.4ms (17 queries, 7 cached) | GC: 0.0ms)
[----] D, [2025-11-13T11:46:05.033555#58401:f7904] DEBUG -- development: output: [null]

Copy link
Member

@jrafanie jrafanie Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, I think the restore needs to have a global lock preventing other threads from handling requests while it's restoring but in the short term, I believe if we track down the sequence here, we can probably resolve the issue in this cypress test by ensuring the report_data intercept and wait is done. cc @asirvadAbrahamVarghese

Copy link
Member

@jrafanie jrafanie Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I used this grep to search my logs for the output above:

grep -E "Started|Completed|output:|Cypress" log/development.log

Copy link
Member

@jrafanie jrafanie Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing it today, we need to intercept and wait on ajax requests. If we use Rack::Lock, there's still a chance thread 1 starts test teardown by doing the restore, but then when it finishes, the remaining ajax request then comes in through thread 2... that could cause the next test to fail if it wasn't expected that activity. So, the current test needs to wait on the POST "/ops/report_data", perhaps only when adding a user, before moving on to ensure it's run before the test teardown and within the correct test.

Copy link
Member

@jrafanie jrafanie Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asirvadAbrahamVarghese let me know if you're able to track down the missing intercepts. I think the Rack::Lock solution is an incomplete solution since we could still have these ajax requests processed AFTER the test that caused them

Copy link
Contributor

@asirvadAbrahamVarghese asirvadAbrahamVarghese Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[----] I, [2025-11-13T11:46:50.460788#58401:f7990]  INFO -- development: Started POST "/ops/x_button?pressed=rbac_user_add" for 127.0.0.1 at 2025-11-13 11:46:50 -0500
[----] I, [2025-11-13T11:46:50.470693#58401:f7990]  INFO -- development: Completed 200 OK in 7ms (Views: 0.1ms | ActiveRecord: 1.9ms (5 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:50.516137#58401:f7990]  INFO -- development: Started GET "/api/groups?&expand=resources" for 127.0.0.1 at 2025-11-13 11:46:50 -0500
[----] I, [2025-11-13T11:46:50.537965#58401:f7990]  INFO -- development: Completed 200 OK in 19ms (Views: 0.0ms | ActiveRecord: 7.2ms (10 queries, 0 cached) | GC: 0.9ms)
[----] I, [2025-11-13T11:46:54.993852#58401:f78a0]  INFO -- development: Started POST "/api/users" for 127.0.0.1 at 2025-11-13 11:46:54 -0500
[----] I, [2025-11-13T11:46:55.010451#58401:f78a0]  INFO -- development: Completed 200 OK in 14ms (Views: 0.0ms | ActiveRecord: 4.0ms (13 queries, 1 cached) | GC: 0.5ms)
[----] I, [2025-11-13T11:46:55.194157#58401:f78a0]  INFO -- development: Started GET "/ops/" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.202310#58401:f78a0]  INFO -- development: Completed 302 Found in 5ms (ActiveRecord: 1.0ms (5 queries, 0 cached) | GC: 0.2ms)
[----] I, [2025-11-13T11:46:55.207715#58401:f78a0]  INFO -- development: Started GET "/ops/explorer" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.247468#58401:f78a0]  INFO -- development: Completed 200 OK in 37ms (Views: 15.6ms | ActiveRecord: 9.6ms (21 queries, 2 cached) | GC: 1.8ms)
[----] I, [2025-11-13T11:46:55.527006#58401:f7904]  INFO -- development: Started GET "/ws/notifications" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.528850#58401:f7904]  INFO -- development: Started GET "/ws/notifications" [WebSocket] for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.529619#58401:d598]  INFO -- development: Started GET "/api/notifications?expand=resources&attributes=details&sort_by=id&sort_order=desc&limit=100" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] I, [2025-11-13T11:46:55.541627#58401:d598]  INFO -- development: Completed 200 OK in 8ms (Views: 0.0ms | ActiveRecord: 2.1ms (9 queries, 0 cached) | GC: 0.3ms)
[----] I, [2025-11-13T11:46:55.647140#58401:d598]  INFO -- development: Started POST "/__e2e__/command" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
[----] D, [2025-11-13T11:46:55.649438#58401:d598] DEBUG -- development: [Cypress] Running db_state restore
[----] I, [2025-11-13T11:46:55.649470#58401:d598]  INFO -- development: [Cypress] DatabaseCleaner restoring
[----] I, [2025-11-13T11:46:55.682052#58401:ef830]  INFO -- development: Started POST "/ops/report_data" for 127.0.0.1 at 2025-11-13 11:46:55 -0500
### ^^^ Another request comes in while database cleaner is restoring

Seeing this 🔝 I am just guessing here, given our current test's flow, the DB restore shouldn’t fire right after/close to adding a user, it probably happened because the test failed due to some reason after add-user event fired and then afterEach hook ran with restore.

So, the current test needs to wait on the POST "/ops/report_data", perhaps only when adding a user, before moving on to ensure it's run before the test teardown and within the correct test.

From the add-user action, these are the requests that get fired. I just tried matching them globally - cy.intercept('*').as('allCalls'); and then forced the test to fail.
image

So there are other requests besides the /ops/report_data one, these other requests could also end up coming in late right?

Copy link
Member

@jrafanie jrafanie Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are other requests besides the /ops/report_data one, these other requests could also end up coming in late right?

Yes, I think you're right. If they are ajax requests that come in and not done sequentially, these other requests could be handled in a thread after the test finished and could be in the teardown.

Rack::Lock would help to ensure we don't process concurrent requests in puma, but that just means they could possibly be processed AFTER the afterEach/teardown is done. We would have to intercept and wait on each OR, if one of them is guaranteed to be fired and processed last, we'd need to do just that one.

Copy link
Member

@jrafanie jrafanie Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I was seeing something similar in the tenant tests. I debugged it and found that we had missing intercepts/waits and in the case of the edit form, there were two API requests to wait on. The add form had a single API wait to do.

#9733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrafanie jrafanie jrafanie left review comments

+3 more reviewers

@jeffibm jeffibm jeffibm left review comments

@asirvadAbrahamVarghese asirvadAbrahamVarghese asirvadAbrahamVarghese left review comments

@elsamaryv elsamaryv elsamaryv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jrafanie jrafanie

@elsamaryv elsamaryv

Labels

enhancement react

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Form conversion: Configuration Acces Control/Users/Configuration/Add a new user

7 participants

@GilbertCherrie @miq-bot @kbrock @asirvadAbrahamVarghese @jrafanie @jeffibm @elsamaryv