-
Notifications
You must be signed in to change notification settings - Fork 366
[WIP] Provider dialogs #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Provider dialogs #4231
Conversation
for now, the button is hardcoded to send the id of the first EmsCloud
this just listens for a message with controller=provider_dialogs and triggers a fake endpoint call, that should return the details
…nd closable closing the modal should be as easy as `const close = () => div.remove();` But.. yay patternfly.
because creating and managing an "instance" when within another react component is just silly this adds a simple `ManageIQ.component.getReact(name)` => the original react component passed to `addReact`
|
So, @martinpovolny the important bits would seem to be ready, What's probably missing right now is integrating the modal buttons with the form buttons. as that requires cooperation from the component. Maybe we could use something like #3509 to separate the buttons from the component. Or maybe we can just add options to |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/89ce342ceddd1a569957cc44a6e8e74d13a96f55~...1f05d27b71ab196600d0324add2cc0a30b82f3cd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/application_helper/toolbar/ems_clouds_center.rb
|
|
@himdel : we don't need this to be done as Modal dialog, it can take the whole page if it's easier to do. Any of the 2 would work. Well at least for now ;-) |
|
@martinpovolny that overflowing dialog is my fault. I thought that patternfly grid layout will work everywhere... it can be fixed very easily.. |
|
@Hyperkid123 : then, please, fix this and ping me in the PR. Thx! |
|
This pull request is not mergeable. Please rebase and repush. |


(The first two commits are #4181.)
This adds a way for toolbar buttons to open modals somehow defined by the provider.
Added the button to Compute > Clouds > Providers list - first button - Magic.
Clicking it will fire a http request (right now,
call_the_endpointfakes it) to get additional data,and based on the response, will render a react component (previously added to the registry by
ManageIQ.component.addReact('name', ...)) or the angular dialog-user component (TODO).Cc @martinpovolny , @Hyperkid123