TextualSummary: remove unneeded physical infra partials

[martinpovolny]

One of the partials is dead. The second can be simply replaced by a generic one.

So remove the 2.

PLEASE, do not add new formatting for textual summaries unless 100% necessary. Actually don't do it at all.

Thx!

This also fixes some i18n in the area.

Relates to:

• TextualSummaries: part of client side rendering with React. #3420
• Change the way that network device details are displayed #3398

Ping @mzazrivec, @AparnaKarve, @skovic

Testing

• use 6_0_dc_MBU_demo_01202018.backup from Dan's folder for test data for physical infra

[miq-bot]

Checked commits martinpovolny/manageiq-ui-classic@5999fdf~...fd3d6a1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[AparnaKarve]

If using TextualCustom is not in the overall best interest, why have it at all?

I was going to suggest to remove it but looks like one other place is using it (app/helpers/vm_helper/textual_summary.rb)

[martinpovolny]

@AparnaKarve : TextualCustom was a way to handle special formatting that could not be done otherwise. It took a significant effort and time to untangle the partials and helpers so that the structure and the similarities showed up.
In that process TextualCustom could also be used to render stuff that was not yet completely cleaned up.

I assumed that people will take the time, read the code and use a generic way where possible and not create stuff that is already created elsewhere. I was wrong in that.

Regarding app/helpers/vm_helper/textual_summary.rb I believe it's handled in #3420

I plan to remove TextualCustom once I finish the rewrite of summaries to React.

[martinpovolny]

@AparnaKarve : Have you checked the PR, can it be merged?

[AparnaKarve]

There are subtle differences in the table styling, which I think is expected with these changes (with TextualTable, that is)

Before -

After -

OK with me & LGTM