Refactor get_rec_cls, add default record_class in the CiProcessing

Author: Hilda Stastna

app/controllers/application_controller/ci_processing.rb

@@ -222,7 +222,7 @@ def breadcrumb_name(_model)
   def process_cloud_object_storage_buttons(pressed)
     assert_privileges(pressed)
 
-    klass = get_rec_cls
+    klass = record_class
     task = pressed.sub("#{klass.name.underscore.to_sym}_", "")
 
     return tag(klass) if task == "tag"
@@ -247,33 +247,12 @@ def cloud_object_store_button_operation(klass, task)
     process_objects(items.ids.sort, method, display_name)
   end
 
-  def get_rec_cls
-    # FIXME: the specs for ci_processing rely on setting (and testing) request.parameters['controller'].
-    # That is wrong and needs to be fixed.
-    case request.parameters["controller"] || controller_name
-    when "miq_template"
-      MiqTemplate
-    when "orchestration_stack"
-      params[:display] == "instances" ? VmOrTemplate : OrchestrationStack
-    when "service"
-      Service
-    when "cloud_object_store_container"
-      params[:pressed].starts_with?("cloud_object_store_object") ? CloudObjectStoreObject : CloudObjectStoreContainer
-    when "cloud_object_store_object"
-      CloudObjectStoreObject
-    when "ems_storage"
-      params[:pressed].starts_with?("cloud_object_store_object") ? CloudObjectStoreObject : CloudObjectStoreContainer
-    when "ems_cluster"
-      %w[all_vms vms].include?(params[:display]) || params[:pressed].starts_with?('miq_template') ? VmOrTemplate : EmsCluster
-    when "storage"
-      %w[all_vms vms].include?(params[:display]) ? VmOrTemplate : Storage
-    else
-      VmOrTemplate
-    end
+  def record_class
+    VmOrTemplate
   end
 
   def process_objects(objs, task, display_name = nil)
-    klass = get_rec_cls
+    klass = record_class
     klass_str = klass.to_s
 
     assert_rbac(klass, objs)
@@ -608,7 +587,7 @@ def process_resourcepools(rps, task)
   #                 on a record
   #   options     - other optional parameters
   def generic_button_operation(action, action_name, operation, options = {})
-    records = find_records_with_rbac(get_rec_cls, checked_or_params)
+    records = find_records_with_rbac(record_class, checked_or_params)
     if testable_action(action) && !records_support_feature?(records, action_to_feature(action))
       javascript_flash(
         :text       => _("%{action_name} action does not apply to selected items") % {:action_name => action_name},

app/controllers/vm_common.rb

@@ -87,7 +87,7 @@ def reload
   end
 
   def show_timeline
-    db = get_rec_cls
+    db = record_class
     @display = "timeline"
     session[:tl_record_id] = params[:id] if params[:id]
     @record = find_record_with_rbac(db, session[:tl_record_id])