Skip to content

Commit 999b07d

Browse files
committed
Drop 'miqApp' webpack compile-time alias
Signed-off-by: Vojtech Szocs <vojtech.szocs@gmail.com>
1 parent cbef26d commit 999b07d

File tree

5 files changed

+2
-11
lines changed

5 files changed

+2
-11
lines changed

.eslintrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"sendDataWithRx": false,
2323
"vanillaJsAPI": false, // local: miq_api.js
2424
"ManageIQ": false, // local: mig_global.js
25-
"miqApp": false, // alias: ManageIQ.angular.app
2625
"Promise": false, // bower: es6-shim
2726
"_": false, // bower: lodash
2827
"__": false, // local: i18n.js

app/javascript/miq-redux/test-helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { IModule } from 'angular';
22

33
import { rootReducer, addReducer, clearReducers, applyReducerHash } from './reducer';
44

5-
const app: IModule = miqApp;
5+
const app: IModule = ManageIQ.angular.app;
66

77
// allow unit-testing specific module exports
88
if (jasmine) {

app/javascript/packs/custom-typings.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33
*/
44
declare const ManageIQ: any;
55

6-
/**
7-
* Compile-time global, alias for `ManageIQ.angular.app`.
8-
*/
9-
declare const miqApp: any;
10-
116
/**
127
* Runtime global, available when running tests with Jasmine.
138
*/

app/javascript/packs/miq-redux-common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { addReducer, applyReducerHash } from '../miq-redux/reducer';
55
import { ReduxStore, ReduxApi } from '../miq-redux/redux-typings';
66
import '../miq-redux/test-helper';
77

8-
const app: IModule = miqApp;
8+
const app: IModule = ManageIQ.angular.app;
99

1010
const initialState = {};
1111

config/webpack/shared.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ module.exports = {
4444

4545
plugins: [
4646
new webpack.EnvironmentPlugin(JSON.parse(JSON.stringify(env))),
47-
new webpack.DefinePlugin({
48-
miqApp: 'ManageIQ.angular.app'
49-
}),
5047
new ExtractTextPlugin(env.NODE_ENV === 'production' ? '[name]-[hash].css' : '[name].css'),
5148

5249
// Workaround for angular/angular#11580

0 commit comments

Comments
 (0)