Merge pull request #6984 from himdel/fix-treeselect

remove-generic-item-modal: fix typeof==undefined bug

Author: mzazrivec

.eslintrc.json

@@ -65,7 +65,9 @@
     "no-unreachable": 2,
     "use-isnan": 2,
     "valid-jsdoc": 2,
-    "valid-typeof": 2,
+    "valid-typeof": [2, {
+      "requireStringLiterals": true
+    }],
     "dot-notation": [2, {
       "allowKeywords": true
     }],

app/javascript/.eslintrc.json

@@ -55,6 +55,9 @@
     "react/jsx-filename-extension": "off",
     "react/destructuring-assignment": [1, "always"],
     "semi": [2, "always"],
-    "space-before-function-paren": [2, "never"]
+    "space-before-function-paren": [2, "never"],
+    "valid-typeof": [2, {
+      "requireStringLiterals": true
+    }]
   }
 }

app/javascript/components/remove-generic-item-modal.jsx

@@ -43,7 +43,7 @@ export const removeItems = (items, apiUrl, asyncDelete, redirectUrl, treeSelect)
     })
     .then((apiData) => {
       if (items.length > 1 || (items.length === 1 && apiData[0].result === 'success')) {
-        if (typeof(treeSelect) == undefined) {
+        if (!treeSelect) {
           window.location.href = redirectUrl;
           miqSparkleOff();
         } else {