Add new specs for record_class method for various controllers

Author: Hilda Stastna

spec/controllers/ems_cluster_controller_spec.rb

@@ -1,5 +1,5 @@
 describe EmsClusterController do
-  context "#button" do
+  describe "#button" do
     it "when VM Right Size Recommendations is pressed" do
       controller.params = {:pressed => "vm_right_size"}
       expect(controller).to receive(:vm_right_size)
@@ -59,6 +59,65 @@
       controller.button
       expect(controller.send(:flash_errors?)).not_to be_truthy
     end
+
+    context 'Smart State Analysis' do
+      let(:cluster) { FactoryBot.create(:ems_cluster) }
+      let(:vm) { FactoryBot.create(:vm_vmware) }
+
+      before do
+        EvmSpecHelper.create_guid_miq_server_zone
+        allow(controller).to receive(:assert_privileges)
+        allow(controller).to receive(:drop_breadcrumb)
+        allow(controller).to receive(:records_support_feature?).and_return(true)
+        allow(controller).to receive(:render)
+        controller.params = {:id => cluster.id.to_s, :miq_grid_checks => vm.id.to_s, :pressed => 'vm_scan' }
+      end
+
+      %w[vms all_vms].each do |display|
+        before { controller.instance_variable_set(:@display, display) }
+
+        it 'initiates SSA for selected VM successfully' do
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@record)).to eq(cluster)
+          expect(controller.instance_variable_get(:@view).db).to eq('Vm')
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Analysis initiated for 1 VM and Instance from the ManageIQ Database', :level => :success}])
+        end
+      end
+
+      context 'nested list of Templates' do
+        let(:template) { FactoryBot.create(:miq_template) }
+
+        before { controller.instance_variable_set(:@display, 'miq_templates') }
+
+        it 'initiates SSA for selected Template successfully' do
+          controller.params = {:display => 'miq_templates', :id => cluster.id.to_s}
+          controller.send(:show)
+          controller.params = {:id => cluster.id.to_s, :miq_grid_checks => template.id.to_s, :pressed => 'miq_template_scan'}
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@record)).to eq(cluster)
+          expect(controller.instance_variable_get(:@view).db).to eq('MiqTemplate')
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Analysis initiated for 1 VM and Instance from the ManageIQ Database', :level => :success}])
+        end
+      end
+
+      context 'list of Clusters' do
+        before do
+          login_as FactoryBot.create(:user)
+          controller.instance_variable_set(:@display, nil)
+          controller.instance_variable_set(:@lastaction, 'show_list')
+          controller.params = {:miq_grid_checks => cluster.id.to_s, :pressed => 'ems_cluster_scan'}
+        end
+
+        it 'returns proper record class' do
+          expect(controller.send(:record_class)).to eq(EmsCluster)
+        end
+
+        it 'initiates SSA for Cluster' do
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Cluster / Deployment Role: scan successfully initiated', :level => :success}])
+        end
+      end
+    end
   end
 
   describe "#show" do

spec/controllers/ems_infra_controller_spec.rb

@@ -1,7 +1,8 @@
 describe EmsInfraController do
   let!(:server) { EvmSpecHelper.local_miq_server(:zone => zone) }
   let(:zone) { FactoryBot.build(:zone) }
-  context "#button" do
+
+  describe "#button" do
     before do
       stub_user(:features => :all)
       EvmSpecHelper.create_guid_miq_server_zone
@@ -90,6 +91,40 @@
       post :button, :params => {:pressed => "vm_transform_mass", :id => ems_infra.id, :format => :js}
       expect(controller.send(:flash_errors?)).not_to be_truthy
     end
+
+    context 'operations on Clusters, Orchestration Stacks, Datastores of selected Provider' do
+      before do
+        controller.params = {:pressed => pressed}
+        controller.instance_variable_set(:@display, display)
+      end
+
+      context 'SSA on selected Clusters from a nested list' do
+        let(:pressed) { 'ems_cluster_scan' }
+        let(:display) { 'ems_clusters' }
+
+        it 'returns proper record class' do
+          expect(controller.send(:record_class)).to eq(EmsCluster)
+        end
+      end
+
+      context 'retirement for Orchestration Stacks displayed in a nested list' do
+        let(:pressed) { 'orchestration_stack_retire_now' }
+        let(:display) { 'orchestration_stacks' }
+
+        it 'returns proper record class' do
+          expect(controller.send(:record_class)).to eq(OrchestrationStack)
+        end
+      end
+
+      context 'SSA on selected Datastores from a nested list' do
+        let(:pressed) { 'storage_scan' }
+        let(:display) { 'storages' }
+
+        it 'returns proper record class' do
+          expect(controller.send(:record_class)).to eq(Storage)
+        end
+      end
+    end
   end
 
   describe "#create" do
@@ -404,11 +439,12 @@
     it { expect(response.status).to eq(200) }
   end
 
-  describe "breadcrumbs path on a 'show' page of an Infrastructure Provider accessed from Dashboard maintab" do
+  context "breadcrumbs path on a 'show' page of an Infrastructure Provider accessed from Dashboard maintab" do
     before do
       stub_user(:features => :all)
       EvmSpecHelper.create_guid_miq_server_zone
     end
+
     context "when previous breadcrumbs path contained 'Cloud Providers'" do
       it "shows 'Infrastructure Providers -> (Summary)' breadcrumb path" do
         ems = FactoryBot.create(:ems_vmware)
@@ -421,9 +457,8 @@
   end
 
   describe "#build_credentials" do
-    before do
-      @ems = FactoryBot.create(:ems_openstack_infra)
-    end
+    before { @ems = FactoryBot.create(:ems_openstack_infra) }
+
     context "#build_credentials only contains credentials that it supports and has a username for in params" do
       let(:default_creds) { {:userid => "default_userid", :password => "default_password"} }
       let(:amqp_creds)    { {:userid => "amqp_userid",    :password => "amqp_password"} }
@@ -463,10 +498,8 @@
     end
   end
 
-  describe "SCVMM - create, update, validate, cancel" do
-    before do
-      login_as FactoryBot.create(:user, :features => %w(ems_infra_new ems_infra_edit))
-    end
+  context "SCVMM - create, update, validate, cancel" do
+    before { login_as FactoryBot.create(:user, :features => %w[ems_infra_new ems_infra_edit]) }
 
     render_views
 
@@ -553,10 +586,8 @@
     end
   end
 
-  describe "Openstack - create, update" do
-    before do
-      login_as FactoryBot.create(:user, :features => %w(ems_infra_new ems_infra_edit))
-    end
+  context "Openstack - create, update" do
+    before { login_as FactoryBot.create(:user, :features => %w[ems_infra_new ems_infra_edit]) }
 
     render_views
 
@@ -634,7 +665,7 @@
     end
   end
 
-  describe "Redhat - create, update" do
+  context "Redhat - create, update" do
     before do
       login_as FactoryBot.create(:user, :features => %w(ems_infra_new ems_infra_edit))
       allow_any_instance_of(ManageIQ::Providers::Redhat::InfraManager)
@@ -737,10 +768,8 @@
     end
   end
 
-  describe "Kubevirt - update" do
-    before do
-      login_as FactoryBot.create(:user, :features => %w(ems_infra_new ems_infra_edit))
-    end
+  context "Kubevirt - update" do
+    before { login_as FactoryBot.create(:user, :features => %w[ems_infra_new ems_infra_edit]) }
 
     render_views
 
@@ -812,10 +841,8 @@
     end
   end
 
-  describe "VMWare - create, update" do
-    before do
-      login_as FactoryBot.create(:user, :features => %w(ems_infra_new ems_infra_edit))
-    end
+  context "VMWare - create, update" do
+    before { login_as FactoryBot.create(:user, :features => %w[ems_infra_new ems_infra_edit]) }
 
     render_views
 

spec/controllers/ems_storage_controller_spec.rb

@@ -40,4 +40,17 @@
       expect(assigns(:ems).id).to eq(ems_storage.id)
     end
   end
+
+  describe '#button' do
+    context 'tagging Cloud Object Store Container' do
+      before do
+        controller.params = {:pressed => 'cloud_object_store_container_tag'}
+        controller.instance_variable_set(:@display, 'cloud_object_store_containers')
+      end
+
+      it 'returns proper record class' do
+        expect(controller.send(:record_class)).to eq(CloudObjectStoreContainer)
+      end
+    end
+  end
 end

spec/controllers/host_controller_spec.rb

@@ -126,6 +126,10 @@
       expect(controller.send(:flash_errors?)).not_to be_truthy
     end
 
+    it 'returns proper record class' do
+      expect(controller.send(:record_class)).to eq(Host)
+    end
+
     context 'provisioning VMS displayed through details page of a Host' do
       before do
         allow(controller).to receive(:process_vm_buttons)
@@ -141,6 +145,32 @@
         expect(controller).to receive(:render_or_redirect_partial).with('vm')
         controller.send(:button)
       end
+
+      it 'returns proper record class' do
+        expect(controller.send(:record_class)).to eq(VmOrTemplate)
+      end
+    end
+
+    context 'SSA on Templates displayed through details page of a Host' do
+      before do
+        controller.params = {:pressed => 'miq_template_scan'}
+        controller.instance_variable_set(:@display, 'miq_templates')
+      end
+
+      it 'returns proper record class' do
+        expect(controller.send(:record_class)).to eq(VmOrTemplate)
+      end
+    end
+
+    context 'SSA on Datastores displayed through details page of a Host' do
+      before do
+        controller.params = {:pressed => 'storage_scan'}
+        controller.instance_variable_set(:@display, 'storages')
+      end
+
+      it 'returns proper record class' do
+        expect(controller.send(:record_class)).to eq(Storage)
+      end
     end
   end
 

spec/controllers/miq_template_controller_spec.rb

@@ -0,0 +1,5 @@
+describe MiqTemplateController do
+  it 'returns proper record class' do
+    expect(controller.send(:record_class)).to eq(MiqTemplate)
+  end
+end

spec/controllers/orchestration_stack_controller_spec.rb

@@ -1,9 +1,7 @@
 describe OrchestrationStackController do
   let!(:user) { stub_user(:features => :all) }
 
-  before do
-    EvmSpecHelper.create_guid_miq_server_zone
-  end
+  before { EvmSpecHelper.create_guid_miq_server_zone }
 
   render_views
 
@@ -229,5 +227,17 @@ def validate_format
         expect(controller.send(:flash_errors?)).not_to be_truthy
       end
     end
+
+    it 'returns proper record class' do
+      expect(controller.send(:record_class)).to eq(OrchestrationStack)
+    end
+
+    context 'Instances displayed through Relationships of Orchestration Stack' do
+      before { controller.params = {:display => 'instances'} }
+
+      it 'returns proper record class' do
+        expect(controller.send(:record_class)).to eq(VmOrTemplate)
+      end
+    end
   end
 end

spec/controllers/resource_pool_controller_spec.rb

@@ -1,8 +1,6 @@
 describe ResourcePoolController do
-  context "#button" do
-    before do
-      controller.instance_variable_set(:@display, "vms")
-    end
+  describe "#button" do
+    before { controller.instance_variable_set(:@display, "vms") }
 
     it "when VM Right Size Recommendations is pressed" do
       controller.params = {:pressed => "vm_right_size"}
@@ -54,6 +52,20 @@
       controller.button
       expect(controller.send(:flash_errors?)).not_to be_truthy
     end
+
+    it 'returns proper record class' do
+      expect(controller.send(:record_class)).to eq(ResourcePool)
+    end
+
+    context 'VMs displayed through Relationships of a Resource Pool' do
+      %w[all_vms vms].each do |display|
+        before { controller.params = {:display => display} }
+
+        it 'returns proper record class' do
+          expect(controller.send(:record_class)).to eq(VmOrTemplate)
+        end
+      end
+    end
   end
 
   describe "#show" do
@@ -76,6 +88,7 @@
 
     context "Direct VMs" do
       let(:url_params) { { :display => "vms" } }
+
       it "renders" do
         bypass_rescue
         expect(subject).to have_http_status(200)
@@ -84,6 +97,7 @@
 
     context "All VMs" do
       let(:url_params) { { :display => "all_vms" } }
+
       it "renders" do
         bypass_rescue
         expect(subject).to have_http_status(200)
@@ -92,6 +106,7 @@
 
     context "Nested Resource Pools" do
       let(:url_params) { { :display => "resource_pools"} }
+
       it "renders" do
         bypass_rescue
         expect(subject).to have_http_status(200)