Push PostgresAdmin.disable_replication into pg-logical_replication

[NickLaMuro]

It was mentioned in a code review regarding PostgresAdmin that the .disable_replication method might make sense being moved into the pg-logical_replication gem. This issue is intended to discuss that topic.

The method in question (not committed to the project at the time of writing) is the following:

private_class_method def self.disable_replication(dbname)
  require 'pg/logical_replication'

  with_pg_connection do |conn|
    pglogical = PG::LogicalReplication::Client.new(conn)

    if pglogical.subscriber?
      pglogical.subcriptions(dbname).each do |subscriber|
        sub_id = subscriber["subscription_name"]
        begin
          pglogical.drop_subscription(sub_id, true)
        rescue PG::InternalError => e
          raise unless e.message.include?("could not connect to publisher")
          raise unless e.message.match?(/replication slot .* does not exist/)

          pglogical.disable_subscription(sub_id).check
          pglogical.alter_subscription_options(sub_id, "slot_name" => "NONE")
          pglogical.drop_subscription(sub_id, true)
        end
      end
    elsif pglogical.publishes?('miq')
      pglogical.drop_publication('miq')
    end
  end
end

I think some changes would be necessary to make it more generic, but this is the method in question.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.