Merge pull request #10337 from jaryn/fix_CodeMirror_filling

[RFR] Fix CodeMirror filling.

Author: mshriver

cfme/tests/services/test_provision_stack.py

@@ -206,7 +206,6 @@ def svc_cleanup(service):
 
 
 @test_requirements.provision
-@pytest.mark.meta(blockers=[BZ(1754543)])
 def test_provision_stack(order_stack, stack_created):
     """Tests stack provisioning
 
@@ -251,7 +250,6 @@ def test_reconfigure_service(appliance, service_catalogs, request):
                       filters=[cloud_filter, not_ec2],
                       selector=ONE_PER_TYPE,
                       scope='module')
-@pytest.mark.meta(blockers=[BZ(1754543)])
 def test_remove_non_read_only_orch_template(appliance, provider, template, service_catalogs,
                                             request):
     """
@@ -316,7 +314,6 @@ def test_remove_read_only_orch_template_neg(appliance, provider, template, order
     assert order_stack.is_succeeded()
 
 
-@pytest.mark.meta(blockers=[BZ(1754543)])
 def test_retire_stack(stack_created):
     """Tests stack retirement.
 
@@ -468,7 +465,6 @@ def _clear_retire_request():
 
 
 @pytest.mark.meta(automates=[1698439])
-@pytest.mark.meta(blockers=[BZ(1754543)])
 @pytest.mark.tier(2)
 @pytest.mark.provider([EC2Provider], selector=ONE, scope='module')
 def test_read_dialog_timeout_ec2_stack(order_stack):

widgetastic_manageiq/__init__.py

@@ -1032,8 +1032,9 @@ class ReactCodeMirror(Widget):
     https://github.com/JedWatson/react-codemirror"""
 
     ROOT = "//div[contains(@class,'miq-codemirror')]//textarea"
-    PARENT_DIV = "./.."  # we need to change visibility of this one
-    CLICK_DIV = "./../.."  # the widget has very nested divs,we need to click on that one ¯\_(ツ)_/¯
+
+    # The CodeMirror has very nested divs, we need to setValue on this one ¯\_(ツ)_/¯.
+    SET_VALUE_ELEMENT = "../.."
 
     def __init__(self, parent, logger=None):
         Widget.__init__(self, parent, logger=logger)
@@ -1042,20 +1043,16 @@ def __init__(self, parent, logger=None):
     def element(self):
         return self.browser.element(self)
 
-    @property
-    def is_editable(self):
-        return self.element.get_attribute("contentEditable") == "true"
-
-    def make_editable(self):
-        if not self.is_editable:
-            self.browser.set_attribute("contentEditable", "true", self)
-
     def fill(self, value):
-        # TODO(anikifor): remove the 2 workarounds below as soon as BZ 1740753 is verified
-        self.make_editable()
-        self.browser.set_attribute("style", "overflow: visible", self.PARENT_DIV)
-        self.browser.element(self.CLICK_DIV).click()
-        self.element.send_keys(value)
+        # CodeMirror is too smart for filling with send_keys.
+        # Fixing BZ#1740753 and BZ#1754543 didn't really help.
+        # Now the problem is that the CodeMirror auto-indents which means
+        # additional indents are created when using send_keys.
+        self.browser.execute_script(
+            """arguments[0].CodeMirror.setValue(arguments[1])""",
+            self.browser.element(self.SET_VALUE_ELEMENT),
+            value,
+        )
         return True
 
     def read(self):