Merge pull request #570 from jrafanie/fix-grammar

Fix grammar and typos

Author: Fryguy

README.md

@@ -38,9 +38,9 @@
 * [Architecture](architecture.md)
 * [Opening custom URLs via Custom Buttons and Automate](automate_url_open.md)
 * [Report data API](ui/report_data_api.md)
-* [Remote Consoles](/remote_consoles.md)
+* [Remote Consoles](remote_consoles.md)
 * [REST API](http://manageiq.org/docs/api)
-* [Service UI Skinning](/service_ui/skinning.md)
+* [Service UI Skinning](service_ui/skinning.md)
 * [Shared react component API](ui/register_react_component.md)
 * [Working with Amazon AWS Config service](providers/amazon_aws_config.md)
 

automate_url_open.md

@@ -34,13 +34,13 @@ Create custom button with Automate method:
       vm.external_url = "https://www.google.com"
 
 ```
-*important: use URL including the protocol (https) or the browser will ignore the request*
+*Important: Use URL including the protocol (https) or the browser will ignore the request*
 
-*also disable URL pop-up blocking in your browser to make this work*
+*Also disable URL pop-up blocking in your browser to make this work*
 
 Automation -> Automate -> Customization -> Buttons
 
-Create a new button for VMs with "Open Url" checked and either w/ or w/o a "Dialog" and "Request" has to be `TestOpenUrl`
+Create a new button for VMs with "Open Url" checked and either with or without a "Dialog" and "Request" has to be `TestOpenUrl`
 
 Go to VM summary page and click the new button.
 

coding_style_and_standards.md

@@ -17,7 +17,7 @@ maintained by the ManageIQ team.
 ## High Level Guidelines
 
 * Be consistent.
-* These guides describes general guidelines to follow for new code.
+* These guides describe general guidelines to follow for new code.
   For existing code, stay consistent with the conventions of the code you
   are changing.
 * Prefer readability over performance and conciseness when the performance
@@ -238,7 +238,7 @@ already pushed them before.
 
 * Reword/squashing/reordering a commit
 
-  To modify with recent commit in current branch, first do
+  To modify recent commits in current branch, first do
   `git rebase -i origin branch-name`.
   To modify a specific commit, use `git rebase -i SOME_COMMIT_ID^` instead.
   git will popup a vi window to let you do modification on commits, press
@@ -251,7 +251,7 @@ already pushed them before.
 
   * Squashing commits
 
-    Change the `pick` before the commit you want to squach to `squash` and edit
+    Change the `pick` before the commit you want to squash to `squash` and edit
     the commit message after squash in a following popup vi window. A commit
     will be squashed with its previous commit.
 

developer_setup.md

@@ -114,7 +114,7 @@ ManageIQ requires a memcached instance for session caching and a PostgreSQL data
 
      Skip ahead to "Start the service"
 
-2. Start the service
+3. Start the service
 
    |            |     |
    | ---------- | --- |
@@ -248,9 +248,9 @@ bundle exec rails console
 simulate_queue_worker
 ```
 
-## macOS AirDrop & Handoff listens on port 5000
+## macOS AirDrop & Handoff Listens on Port 5000
 
-If you run workers like we do on appliances using `ruby lib/workers/bin/evm_server.rb` remote console workers will try to bind to port 5000.  This can fail on macOS with:
+If you run workers like we do on appliances using `ruby lib/workers/bin/evm_server.rb`, remote console workers will try to bind to port 5000. This can fail on macOS with:
 
 ```
 Address already in use - bind(2) for "0.0.0.0" port 5000

external_auth.md

@@ -1,4 +1,4 @@
 # External Authentication (httpd)
 
-- [Development with an OIDC server](./external_auth/oidc)
-- [Development with an IPA server](./external_auth/ipa)
+- [Development with an OIDC server](./external_auth/oidc.md)
+- [Development with an IPA server](./external_auth/ipa.md)

i18n.md

@@ -43,9 +43,9 @@ The following gettext routines are supported in Ruby and HAML sources:
   * [rubydoc](http://www.rubydoc.info/gems/gettext/GetText#N_-instance_method)
 * `n_(msgid, msgid_plural, n)` – returns either translated `msgid` or its translated plural form (`msgid_plural`) depending on `n`, a number determining the count (i.e. number above 1 means plural form)
   * [rubydoc](http://www.rubydoc.info/gems/gettext/GetText#ngettext-instance_method)
-* `s_(msgid, seperator = "|")` – translates `msgid`, but if there are no localized text, it returns a last part of `msgid` separated by `separator` (`|` by default)
+* `s_(msgid, separator = "|")` – translates `msgid`, but if there is no localized text, it returns a last part of `msgid` separated by `separator` (`|` by default)
   * [rubydoc](http://www.rubydoc.info/gems/gettext/GetText#sgettext-instance_method)
-* `ns_(msgid, msgid_plural, n, seperator = "|")` – similar to the `n_()`, but if there is no localized text, it returns a last part of `msgid` separated by `separator`.
+* `ns_(msgid, msgid_plural, n, separator = "|")` – similar to the `n_()`, but if there is no localized text, it returns a last part of `msgid` separated by `separator`.
   * [rubydoc](http://www.rubydoc.info/gems/gettext/GetText#ngettext-instance_method)
 
 ### JavaScript
@@ -145,8 +145,8 @@ The above should correctly be:
 
 ```html
 <span>
-  <span ng=if="magicVaiable" translate>It's there</span>
-  <span ng=if="!magicVariable" translate>It's not there</span>
+  <span ng-if="magicVariable" translate>It's there</span>
+  <span ng-if="!magicVariable" translate>It's not there</span>
 </span>
 ```
 

labels.md

@@ -4,43 +4,43 @@ Below are charts describing all of the common labels and colors across the Manag
 
 Color | Hex | Description
 --- | --- | ---
-![](https://dummyimage.com/100x20/ee0701&text=+) | `#ee0701` | Scope - Bugs
-![](https://dummyimage.com/100x20/84b6eb&text=+) | `#84b6eb` | Scope - Enhancement
-![](https://dummyimage.com/100x20/bfe5bf&text=+)![](https://dummyimage.com/100x20/bcf5db&text=+) | `#bfe5bf``#bcf5db` | Scope - Testing and tools: "test", "developer", "tools"
-![](https://dummyimage.com/100x20/fef2c0&text=+)![](https://dummyimage.com/100x20/e99695&text=+) ![](https://dummyimage.com/100x20/fbca04&text=+)![](https://dummyimage.com/100x20/ff7619&text=+) | `#fef2c0``#e99695``#fbca04``#ff7619` | Scope - Other: "cleanup", "performance", "refactoring", "technical debt"
-![](https://dummyimage.com/100x20/0e8a16&text=+) | `#0e8a16` | Positive statuses: "help wanted", "verified"
-![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | Negative statuses: "duplicate", "notabug", "stale", "unmergeable", "wip", "wontfix"
-![](https://dummyimage.com/100x20/cc317c&text=+) | `#cc317c` | Questions and discussions: "question"
-![](https://dummyimage.com/100x20/5319e7&text=+) | `#5319e7` | Component: Repo specific labels that categorize what parts of the application are being changed.  See the repos for specifics.
-![](https://dummyimage.com/100x20/d4c5f9&text=+) | `#d4c5f9` | Alternate component: A secondary, repo specific categorization (e.g. in manageiq-ui-classic, dark purple represents a specific UI tab being changed, whereas light purple is used for general components like toolbars or buttons)
-![](https://dummyimage.com/100x20/b4a8d1&text=+) | `#b4a8d1` | Special component: A component that requires more careful handling and possibly a specific reviewer or merger. Right now this is only "dependencies" and "sql migration".
-![](https://dummyimage.com/100x20/000000&text=+)![](https://dummyimage.com/100x20/555555&text=+) ![](https://dummyimage.com/100x20/dddddd&text=+) | `#000000``#555555``#dddddd` | Backporting and release: "blocker", "fine/yes", "fine/no", "darga/yes", "darga/no", etc.  The darkest color is for the most recent release, the middle color is the release before that, and the lightest color is for any release older than that.
+![](https://dummyimage.com/100x20/ee0701&text=+) | `#ee0701` | Scope - Bugs
+![](https://dummyimage.com/100x20/84b6eb&text=+) | `#84b6eb` | Scope - Enhancement
+![](https://dummyimage.com/100x20/bfe5bf&text=+)![](https://dummyimage.com/100x20/bcf5db&text=+) | `#bfe5bf` `#bcf5db` | Scope - Testing and tools: "test", "developer", "tools"
+![](https://dummyimage.com/100x20/fef2c0&text=+)![](https://dummyimage.com/100x20/e99695&text=+) ![](https://dummyimage.com/100x20/fbca04&text=+)![](https://dummyimage.com/100x20/ff7619&text=+) | `#fef2c0` `#e99695` `#fbca04` `#ff7619` | Scope - Other: "cleanup", "performance", "refactoring", "technical debt"
+![](https://dummyimage.com/100x20/0e8a16&text=+) | `#0e8a16` | Positive statuses: "help wanted", "verified"
+![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | Negative statuses: "duplicate", "notabug", "stale", "unmergeable", "wip", "wontfix"
+![](https://dummyimage.com/100x20/cc317c&text=+) | `#cc317c` | Questions and discussions: "question"
+![](https://dummyimage.com/100x20/5319e7&text=+) | `#5319e7` | Component: Repo specific labels that categorize what parts of the application are being changed.  See the repos for specifics.
+![](https://dummyimage.com/100x20/d4c5f9&text=+) | `#d4c5f9` | Alternate component: A secondary, repo specific categorization (e.g. in manageiq-ui-classic, dark purple represents a specific UI tab being changed, whereas light purple is used for general components like toolbars or buttons)
+![](https://dummyimage.com/100x20/b4a8d1&text=+) | `#b4a8d1` | Special component: A component that requires more careful handling and possibly a specific reviewer or merger. Right now this is only "dependencies" and "sql migration".
+![](https://dummyimage.com/100x20/000000&text=+)![](https://dummyimage.com/100x20/555555&text=+) ![](https://dummyimage.com/100x20/dddddd&text=+) | `#000000` `#555555` `#dddddd` | Backporting and release: "blocker", "fine/yes", "fine/no", "darga/yes", "darga/no", etc.  The darkest color is for the most recent release, the middle color is the release before that, and the lightest color is for any release older than that.
 
 ### Common labels
 
 Label | Color | Hex | Description
 --- | --- | --- | ---
-blocker | ![](https://dummyimage.com/100x20/000000&text=+) | `#000000` | Blocker for the next release.
-bug | ![](https://dummyimage.com/100x20/ee0701&text=+) | `#ee0701` | A bug.
-bug/sporadic test failure | ![](https://dummyimage.com/100x20/ee0701&text=+) | `#ee0701` | A bug that manifests as test failures in an unpredictable way.
-cleanup | ![](https://dummyimage.com/100x20/fef2c0&text=+) | `#fef2c0` | Changes only making the code cleaner and that do not change how the code works nor the outputs produced (e.g. rubocop or eslint changes).
-dependencies | ![](https://dummyimage.com/100x20/b4a8d1&text=+) | `#b4a8d1` | Changes that affect dependencies, such as gem changes.
-developer | ![](https://dummyimage.com/100x20/bcf5db&text=+) | `#bcf5db` | Changes that affect developers only, including non-customer-facing tools (e.g. changes to bin/setup)
-documentation | ![](https://dummyimage.com/100x20/d4c5f9&text=+) | `#d4c5f9` | Changes to documentation only (e.g. README.md).
-duplicate | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue is a duplicate.  When applied, the duplicate issue should be referenced in a comment.
-enhancement | ![](https://dummyimage.com/100x20/84b6eb&text=+) | `#84b6eb` | An enhancement.
-help wanted | ![](https://dummyimage.com/100x20/0e8a16&text=+) | `#0e8a16` | An issue that could be handled by anyone, even new members of the community.
-internationalization | ![](https://dummyimage.com/100x20/d4c5f9&text=+) | `#d4c5f9` | Changes that are for internationalization only (e.g. updating the *.po gettext files).
-notabug | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue is not a bug as reported or not reproducible.  When applied the issue should be closed.
-performance | ![](https://dummyimage.com/100x20/e99695&text=+) | `#e99695` | Changes that are for performance improvements only.
-pinned | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue will not be marked by [**@miq-bot**](https://github.com/miq-bot) with the stale label.
-question | ![](https://dummyimage.com/100x20/cc317c&text=+) | `#cc317c` | Issues that are just questions.  When the question is resolved, the label should be changed and/or the issue should be closed.
-refactoring | ![](https://dummyimage.com/100x20/fbca04&text=+) | `#fbca04` | Changes in the way the code works internally without changing the output produced.  Contrast to "cleanup".
-stale | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue is old and hasn't had activity in 6 months.  This label will be automatically applied by [**@miq-bot**](https://github.com/miq-bot).
-technical debt | ![](https://dummyimage.com/100x20/ff7619&text=+) | `#ff7619` | Changes that remove or significantly update old unused code and/or dependencies.
-test | ![](https://dummyimage.com/100x20/bfe5bf&text=+) | `#bfe5bf` | Changes to test code only.
-tools | ![](https://dummyimage.com/100x20/bcf5db&text=+) | `#bcf5db` | Changes to customer-facing tools (e.g. tools/prune_metrics.rb). Contrast to "developer".
-unmergeable | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The PR is unmergeable.  This label is automatically applied and removed by [**@miq-bot**](https://github.com/miq-bot).
-verified | ![](https://dummyimage.com/100x20/0e8a16&text=+) | `#0e8a16` | The bug issue was reviewed and is verified to have the problem stated and a PR should be created.  This label is not necessary on a bug PR.
-wip | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The PR is a WIP.  This label is automatically applied and removed by [**@miq-bot**](https://github.com/miq-bot) based on PR title having "[WIP]" or not.
-wontfix | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue will not be fixed or otherwise handled.  When applied, the issue should be closed.
+blocker | ![](https://dummyimage.com/100x20/000000&text=+) | `#000000` | Blocker for the next release.
+bug | ![](https://dummyimage.com/100x20/ee0701&text=+) | `#ee0701` | A bug.
+bug/sporadic test failure | ![](https://dummyimage.com/100x20/ee0701&text=+) | `#ee0701` | A bug that manifests as test failures in an unpredictable way.
+cleanup | ![](https://dummyimage.com/100x20/fef2c0&text=+) | `#fef2c0` | Changes only making the code cleaner and that do not change how the code works nor the outputs produced (e.g. rubocop or eslint changes).
+dependencies | ![](https://dummyimage.com/100x20/b4a8d1&text=+) | `#b4a8d1` | Changes that affect dependencies, such as gem changes.
+developer | ![](https://dummyimage.com/100x20/bcf5db&text=+) | `#bcf5db` | Changes that affect developers only, including non-customer-facing tools (e.g. changes to bin/setup)
+documentation | ![](https://dummyimage.com/100x20/d4c5f9&text=+) | `#d4c5f9` | Changes to documentation only (e.g. README.md).
+duplicate | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue is a duplicate.  When applied, the duplicate issue should be referenced in a comment.
+enhancement | ![](https://dummyimage.com/100x20/84b6eb&text=+) | `#84b6eb` | An enhancement.
+help wanted | ![](https://dummyimage.com/100x20/0e8a16&text=+) | `#0e8a16` | An issue that could be handled by anyone, even new members of the community.
+internationalization | ![](https://dummyimage.com/100x20/d4c5f9&text=+) | `#d4c5f9` | Changes that are for internationalization only (e.g. updating the *.po gettext files).
+notabug | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue is not a bug as reported or not reproducible.  When applied the issue should be closed.
+performance | ![](https://dummyimage.com/100x20/e99695&text=+) | `#e99695` | Changes that are for performance improvements only.
+pinned | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue will not be marked by [**@miq-bot**](https://github.com/miq-bot) with the stale label.
+question | ![](https://dummyimage.com/100x20/cc317c&text=+) | `#cc317c` | Issues that are just questions.  When the question is resolved, the label should be changed and/or the issue should be closed.
+refactoring | ![](https://dummyimage.com/100x20/fbca04&text=+) | `#fbca04` | Changes in the way the code works internally without changing the output produced.  Contrast to "cleanup".
+stale | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue is old and hasn't had activity in 6 months.  This label will be automatically applied by [**@miq-bot**](https://github.com/miq-bot).
+technical debt | ![](https://dummyimage.com/100x20/ff7619&text=+) | `#ff7619` | Changes that remove or significantly update old unused code and/or dependencies.
+test | ![](https://dummyimage.com/100x20/bfe5bf&text=+) | `#bfe5bf` | Changes to test code only.
+tools | ![](https://dummyimage.com/100x20/bcf5db&text=+) | `#bcf5db` | Changes to customer-facing tools (e.g. tools/prune_metrics.rb). Contrast to "developer".
+unmergeable | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The PR is unmergeable.  This label is automatically applied and removed by [**@miq-bot**](https://github.com/miq-bot).
+verified | ![](https://dummyimage.com/100x20/0e8a16&text=+) | `#0e8a16` | The bug issue was reviewed and is verified to have the problem stated and a PR should be created.  This label is not necessary on a bug PR.
+wip | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The PR is a WIP.  This label is automatically applied and removed by [**@miq-bot**](https://github.com/miq-bot) based on PR title having "[WIP]" or not.
+wontfix | ![](https://dummyimage.com/100x20/eeeeee&text=+) | `#eeeeee` | The issue will not be fixed or otherwise handled.  When applied, the issue should be closed.

logical_replication_migrations.md

@@ -3,7 +3,7 @@
 ## Introduction
 
 ManageIQ uses logical replication to provide central administrative functions over objects in other
-database regions.  In order to do this, postgresql's logical replication is used to setup
+database regions.  In order to do this, PostgreSQL's logical replication is used to set up
 publications for specific tables in remote regions and subscriptions for each in the central or
 global region.
 
@@ -21,7 +21,7 @@ This logic is what we're trying to test and verify.
 
 ## Pre-requisites
 
-This was tested with 3 nightly appliances.  They were setup to be at the Jansa codebase with
+This was tested with 3 nightly appliances.  They were set up to be at the Jansa codebase with
 replication. The appliances were then migrated to kasparov.  This document could be used for
 different branches or tags.
 
@@ -105,7 +105,7 @@ Substitute XXX for the region number of this appliance:
 
 ## Configure replication for jansa
 
-* Region 1 and 2: 
+* Region 1 and 2:
   * These will be remotes, meaning they will "publish" the tables to be replicated:
 
   ```
@@ -118,12 +118,12 @@ Substitute XXX for the region number of this appliance:
   * The commands below will:
     * Provide the other regions' connection information
     * Create the subscription for each remote region
-  
+
   ```
   bin/rails c
   ```
 
-  Subsitute the proper values below:
+  Substitute the proper values below:
 
   ```
   $ require 'miq_pglogical'
@@ -137,7 +137,7 @@ Substitute XXX for the region number of this appliance:
   MiqPglogical.save_global_region([sub1, sub2], [])
   ```
 
-Now, replication can verified before moving on.
+Now, replication can be verified before moving on.
 
 On the global: