Skip to content

fix #469 segfault in timer.when() after it has fired/cancelled #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jensbjorgensen
Copy link
Contributor

instead cache that value at start-time

(and also)
ignore uvloop-dev (especially since dev instructions specify that you create it)
fix loop.pyi _TransProtPair which fails in python >=3.8

…elled, instead cache that value at start-time

ignore uvloop-dev (especially since dev instructions specify that you create it)
@jensbjorgensen
Copy link
Contributor Author

@elprans have a minute to take a look at this? it'd be good to fix this segfault... also if you have a chance to look at my feature pull request for the filesystem monitoring that would be super cool

@fantix fantix closed this in c39afff Jul 16, 2022
@fantix
Copy link
Member

fantix commented Jul 16, 2022

Thank you for the PR! I think it's overall good, though I'd do it slightly differently. Merged in c39afff and fae5f7f.

@jensbjorgensen jensbjorgensen deleted the timer_segfault_fix branch July 18, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants