Skip to content

fix None _shutdown_timeout_handle issue #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2019
Merged

fix None _shutdown_timeout_handle issue #290

merged 1 commit into from
Oct 25, 2019

Conversation

fantix
Copy link
Member

@fantix fantix commented Oct 25, 2019 •
edited
Loading

1st1
1st1 reviewed Oct 25, 2019
View reviewed changes
@fantix fantix force-pushed the fix_none_shutdown_timeout_handle branch 2 times, most recently from fd6a4e3 to 4d58de4 Compare October 25, 2019 04:02
@fantix fantix changed the title fix None _shutdown_timeout_handle issue [WIP] fix None _shutdown_timeout_handle issue Oct 25, 2019
@fantix fantix force-pushed the fix_none_shutdown_timeout_handle branch 2 times, most recently from 920ae1b to 45e6101 Compare October 25, 2019 04:49
@fantix
fix None _shutdown_timeout_handle issue
8538374 
* Fixes MagicStack#255
* Also make handles more robust
@fantix fantix force-pushed the fix_none_shutdown_timeout_handle branch from 45e6101 to 8538374 Compare October 25, 2019 05:41
@fantix fantix changed the title [WIP] fix None _shutdown_timeout_handle issue fix None _shutdown_timeout_handle issue Oct 25, 2019
@1st1 1st1 merged commit 7fcbfed into MagicStack:master Oct 25, 2019
@1st1
Copy link
Member

1st1 commented Oct 25, 2019

Thank you @fantix!

@fantix fantix deleted the fix_none_shutdown_timeout_handle branch October 25, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error on transport TCPTransport leads to AttributeError: 'NoneType' object has no attribute 'cancel'
2 participants
@fantix @1st1