File tree Expand file tree Collapse file tree 2 files changed +17
-11
lines changed Expand file tree Collapse file tree 2 files changed +17
-11
lines changed Original file line number Diff line number Diff line change @@ -549,10 +549,15 @@ async def test_client(addr):
549
549
t .set_protocol (p )
550
550
551
551
self .assertFalse (t ._paused )
552
+ self .assertTrue (t .is_reading ())
552
553
t .pause_reading ()
554
+ t .pause_reading () # Check that it's OK to call it 2nd time.
553
555
self .assertTrue (t ._paused )
556
+ self .assertFalse (t .is_reading ())
554
557
t .resume_reading ()
558
+ t .resume_reading () # Check that it's OK to call it 2nd time.
555
559
self .assertFalse (t ._paused )
560
+ self .assertTrue (t .is_reading ())
556
561
557
562
sock = t .get_extra_info ('socket' )
558
563
self .assertIs (sock , t .get_extra_info ('socket' ))
@@ -580,6 +585,12 @@ async def test_client(addr):
580
585
t .abort ()
581
586
self .assertTrue (t ._closing )
582
587
588
+ self .assertFalse (t .is_reading ())
589
+ # Check that pause_reading and resume_reading don't raise
590
+ # errors if called after the transport is closed.
591
+ t .pause_reading ()
592
+ t .resume_reading ()
593
+
583
594
await fut
584
595
585
596
# Test that peername and sockname are available after
Original file line number Diff line number Diff line change @@ -664,21 +664,16 @@ cdef class UVStream(UVBaseTransport):
664
664
def can_write_eof (self ):
665
665
return True
666
666
667
- def pause_reading (self ):
668
- self ._ensure_alive ()
667
+ def is_reading (self ):
668
+ return self ._is_reading ()
669
669
670
- if self ._closing:
671
- raise RuntimeError (' Cannot pause_reading() when closing' )
672
- if not self ._is_reading():
673
- raise RuntimeError (' Already paused' )
670
+ def pause_reading (self ):
671
+ if self ._closing or not self ._is_reading():
672
+ return
674
673
self ._stop_reading()
675
674
676
675
def resume_reading (self ):
677
- self ._ensure_alive()
678
-
679
- if self ._is_reading():
680
- raise RuntimeError (' Not paused' )
681
- if self ._closing:
676
+ if self ._is_reading() or self ._closing:
682
677
return
683
678
self ._start_reading()
684
679
You can’t perform that action at this time.
0 commit comments