Fix API version in yr weather provider call

[rejas]

Fixes #3227

and also

• removes unused code
• de-duplicates code fragments
• fixes typos
• inlines code
• adds more weather util tests

@martingron and @Justheretoreportanissue would you be so kind to check if I didnt mess anything up?

[khassel]

LGTM but what about my comment in the issue

We should introduce apiVersionSunrise and apiVersionLocationforecast so users can change this in config.js.

can you add this too? So users could change this in config.js without waiting for next release or hacking the code

[rejas]

can you add this too? So users could change this in config.js without waiting for next release or hacking the code

will do that, until then I revert this to a "draft"

[matt-thurling]

I noticed that sometime in the last couple of days they've switched off the 2.3 API for the sunset data too (i.e. line 355) so that's now returning a 404.
I've had a quick look at the doco and api response, and it appears that the 3.0 API has changed a fair bit for sunset - so wouldn't be as simple as bumping the number. Edit: nvm - I played with the code a bit closer and figured out what it's doing. I think bumping that number to 3.0 would be enough to get it to work ;)