-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a WeatherProvider for Open-Meteo #2964
Conversation
@rejas can you please take a look? Thanks! |
8be5ff0
to
74601d9
Compare
@rejas Changes suggested marked as solved |
Trying out your PR I get an error with this config:
Error is:
It seems it tries to guess the timezone? Is that really necessary for a current weather call? |
I'll take a look. Thx |
@rejas I've removed support for moment-timezone in favor of API Documentation's param Please refer to Open-Meteo Weather Forecast API |
hourly: this.hourlyParams, | ||
// Fixed units as metric | ||
temperature_unit: "celsius", | ||
windspeed_unit: "kmh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wind units need to be stored in meters per second in the weatherobject, not kmh. Please convert them if the api doesnt provide that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isnt fixed yet
- Forecast type bug fixed. Use of type should be working now. - Skipping offset of start date (avoiding use of in provider.
Since the year is rapidly nearing its end (and therefore a new release is coming up soon) I would propose to merge this even though it still has a bug (or two depending if I caught them all).
Any comments @angeldeejay @khassel @sdetweil @MichMich ? |
@rejas feel free to merge ... |
Merging this in the holiday spirit :-) @angeldeejay would be nice if you could add some documentation to the doc repo for this provider (https://github.com/MichMich/MagicMirror-Documentation) and in the new year see if you can fix the remaining bugs. Happy holidays everyone! |
I'll be adding more explained docs about this feature. Thanks for your effort |
hi @angeldeejay I wanted to check in if you are still interested in updating the documentation or if you need support for that? |
Off course!, I had some personal issues the last month, but I'll be updating documentation for this provider. Sorry |
@rejas Please refer to: |
Resolved technical debt for [2964](#2964): - Set wind speed unit to m/s - Rename parameter `past_days` to `pastDays` to be consistent with all configs
Added Weather Provider for Open-Meteo.
I've found a completely free weather REST API (event with option of self-hosting) after having problems with API keys from all MagicMirror weather providers currently implemented (the remote services, not the providers themselves).
This API doesn't return information about reverse geocode from latitude and longitude options like others. I solved that issue using another free API.
APIs used
Considerations
apiKey
parameter. It's not used at all. Onlylatitude
andlongitude
are required.Config examples: