Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config:check dependencies listed in devdependencies #2109

Closed
sdetweil opened this issue Aug 6, 2020 · 4 comments
Closed

config:check dependencies listed in devdependencies #2109

sdetweil opened this issue Aug 6, 2020 · 4 comments

Comments

@sdetweil
Copy link
Collaborator

sdetweil commented Aug 6, 2020

to reduce space on SD card, my installer does npm install only=prod, which leaves off devDependencies, and all the prettier, etc stuff is listed there. needs to be moved to the production dependencies.

npm run config:check fails missing prettier etc

@khassel
Copy link
Collaborator

khassel commented Aug 6, 2020

same setup, and after running npm install, which installs devDependencies, still the same error:

> magicmirror@2.13.0-develop config:check /opt/magic_mirror
> node js/check_config.js

[2020-08-06 22:52:57.222] [INFO]   Checking file...  /opt/magic_mirror/config/config.js
[2020-08-06 22:52:57.267] [LOG]    Line 1 col 1 Definition for rule 'prettier/prettier' was not found.
/opt/magic_mirror/js/check_config.js:66
                        throw new Error("Wrong syntax in config file!");
                        ^

Error: Wrong syntax in config file!
    at /opt/magic_mirror/js/check_config.js:66:10

The syntax of config.js is correct.

Could be related to prettier stuff, so may @rejas can take a look at this?

@rejas
Copy link
Collaborator

rejas commented Aug 7, 2020

Took a look, made a PR :-)

@sdetweil
Copy link
Collaborator Author

sdetweil commented Aug 7, 2020

see note on pr

@sdetweil
Copy link
Collaborator Author

sdetweil commented Sep 7, 2020

looks good

@sdetweil sdetweil closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants