Skip to content

Commit 291ae85

Browse files
Handle "module is not defined" in e2e tests (#3647)
Even in successful tests, there are many module not defined` error entries. Like this: https://github.com/MagicMirrorOrg/MagicMirror/actions/runs/12199106844/job/34032254241#step:5:353 I think we can suppress them.
1 parent 63178eb commit 291ae85

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ _This release is scheduled to be released on 2025-01-01._
2424

2525
### Removed
2626

27-
- [tests] Removed node-pty and drivelist from rebuilded test (#3575)
27+
- [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575)
2828
- [deps] Remove `@eslint/js` dependency. Already installed with `eslint` in deep (#3636)
2929

3030
### Updated
@@ -43,7 +43,8 @@ _This release is scheduled to be released on 2025-01-01._
4343
- [tests] Fix test cases with hard coded Date.now (#3597)
4444
- [core] Fix missing `basePath` where `location.host` is used (#3613)
4545
- [compliments] croner library changed filenames used in latest version (#3624)
46-
- [linter] Fix ESLint ignore pattern which caused that default modules not to be linted. (#3632).
46+
- [linter] Fix ESLint ignore pattern which caused that default modules not to be linted (#3632)
47+
- [tests] Suppress "module is not defined" in e2e tests
4748

4849
## [2.29.0] - 2024-10-01
4950

tests/e2e/helpers/mock-console.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const mockError = (err) => {
88
|| err.includes("ECONNRESET")
99
|| err.includes("socket hang up")
1010
|| err.includes("exports is not defined")
11+
|| err.includes("module is not defined")
1112
|| err.includes("write EPIPE")
1213
|| err.includes("AggregateError")
1314
|| err.includes("ERR_SOCKET_CONNECTION_TIMEOUT")

0 commit comments

Comments
 (0)