Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full support for Multi module projects #50

Merged
merged 48 commits into from
Jul 25, 2023
Merged

Full support for Multi module projects #50

merged 48 commits into from
Jul 25, 2023

Conversation

thsaravana
Copy link
Member

Fixes #49 #20 #28

Screenshot 2023-07-25 at 01 17 15
  • If the project is Multi Module, then there will now be a Module wise coverage report.
  • If the project has no module (single module), then we will just show the File information.
  • Only Files and Modules, that are part of the "changed files" in the PR will show up in the report.
  • The paths now supports wildcard entries (glob).
  • Did a lot of code cleanup

Testing using this PR: thsaravana/jacoco-android-playground#9

@thsaravana
Add validation for required inputs
65e0b55
@thsaravana
Tech Debt - Adding eslint
03f18cc
@thsaravana
Tech Debt - Adding prettier and fixing existing issues
23e2b02
@thsaravana
Tech Debt - Removing webpack
a3db001
@thsaravana
Tech Debt - Fixing warnings
c301c80
@thsaravana
Tech Debt - Fixing single quote
56d58c0
@thsaravana
Tech Debt - Turning off the dot-notation rule
d73519c
@thsaravana
Tech Debt - Cleaning up test file warnings
d399b61
@thsaravana
Tech Debt - Fixing the context const issue in test files
f9e1102
@thsaravana
Send the Modules coverage information to action from process
80c5d32
@thsaravana
Passing coverage-changed-files from process
bc4b4ae
@thsaravana
Adding Module table (removed files table temporarily)
37752cb
@thsaravana
Adding Files table back in
96a2946
@thsaravana
Fixing the table formatting issues
a49faa0
@thsaravana
Fixing the Files status issue
b4419c6
@thsaravana
Render will add PR comment for Single and Multi module
f2367a9
@thsaravana
Fixing the action test cases
53e9167
@thsaravana
Testing the glob pattern matching
5345c33
@thsaravana
Testing the glob pattern matching
7a2a3d7
@thsaravana
Using globSync
575fff8
@thsaravana
Logging path
37b3821
@thsaravana
Filtering empty paths
6b8f1ae
@thsaravana
typeof check for path returned
33ad78e
@thsaravana
Fixing the path type
d62784f
@thsaravana
Fixing the path type
fb12b7b
@thsaravana
Debugging the getJsonReports function
e581f33
@thsaravana
Passing array directly to globSync
faa89e8
@thsaravana
Replacing globSync with glob
eada1b7
@thsaravana
Testing the @actions/glob
f93e18a
@thsaravana
Revert "Testing the @actions/glob"
b366372 
This reverts commit f93e18a.
@thsaravana thsaravana added the feature request New feature or request label Jul 24, 2023
@thsaravana thsaravana added this to the 1.5 milestone Jul 24, 2023
@thsaravana thsaravana requested a review from instrap July 24, 2023 23:21
@thsaravana thsaravana self-assigned this Jul 24, 2023
@instrap
Copy link
Member

instrap commented Jul 25, 2023

We should add eslint and prettier check to the check.yml

instrap
instrap reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@instrap instrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Make sure to update the README.md and action.yml, mentioning the support for wildcards in paths input.

@thsaravana thsaravana requested a review from instrap July 25, 2023 10:43
@thsaravana thsaravana merged commit 4a4edd0 into main Jul 25, 2023
1 check passed
@thsaravana thsaravana deleted the multi-module-support branch July 25, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instrap instrap instrap approved these changes

Assignees

@thsaravana thsaravana

Labels
feature request New feature or request
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Full support for multi-module projects
2 participants
@thsaravana @instrap