properly escape quotes

Author: philschatz

readme2tex/render.py

@@ -7,6 +7,7 @@
 import tempfile
 import xml.etree.ElementTree as ET
 from subprocess import check_output
+from xml.sax.saxutils import quoteattr
 import logging
 
 envelope = r'''%% processed with readme2tex
@@ -25,17 +26,6 @@
 except NameError:
     pass
 
-html_escape_dict = {
-    '"': '"',
-    '\n': '
',
-    '<': '&lt;',
-}
-
-def replace_all(text, dic):
-  for i, j in dic.iteritems():
-    text = text.replace(i, j)
-  return text
-
 def rendertex(engine, string, packages, temp_dir, block):
     if engine != 'latex': raise Exception("Not Implemented")
     source = envelope % ('\n'.join(r'\usepackage{%s}' % ''.join(package) for package in packages), 'a' if not block else '', string)
@@ -327,8 +317,8 @@ def render(
             tail.append('%x' % random.randint(0, 1e12))
         if needs_inversion:
             tail.append('invert_in_darkmode')
-        img = '<img alt="%s" src="%s%s" %s width="%spt" height="%spt"/>' % (
-            replace_all(equation, html_escape_dict),
+        img = '<img alt=%s src="%s%s" %s width="%spt" height="%spt"/>' % (
+            quoteattr(equation),
             url,
             '?%s' % ('&'.join(tail)) if tail else '',
             ('valign=%spx'%(-off * scale) if use_valign else 'align=middle'),