feat(vscode): make Builders and Needs Attention rows clickable

Clicking a row in the Builders sidebar (or a blocked-builder row in
Needs Attention) now opens that builder's terminal in the editor —
previously these rows were decorative because no `command` was wired.

Lifts the role-id-to-terminalId resolution out of
BuilderTerminalLinkProvider into TerminalManager.openBuilderByRoleOrId
so the sidebar tree views, terminal link provider, and a new
`codev.openBuilderById` command all share one path. The link provider
loses its now-unused ConnectionManager and OutputChannel deps.

Author: amrmelsayed

packages/vscode/src/extension.ts

@@ -176,6 +176,10 @@ export async function activate(context: vscode.ExtensionContext) {
 				vscode.window.showErrorMessage('Codev: Failed to create shell');
 			}
 		}),
+		vscode.commands.registerCommand('codev.openBuilderById', async (roleOrId: string) => {
+			if (!roleOrId) { return; }
+			await terminalManager?.openBuilderByRoleOrId(roleOrId);
+		}),
 		vscode.commands.registerCommand('codev.spawnBuilder', () => spawnBuilder()),
 		vscode.commands.registerCommand('codev.sendMessage', () => sendMessage(connectionManager!)),
 		vscode.commands.registerCommand('codev.approveGate', () => approveGate(connectionManager!)),
@@ -200,7 +204,7 @@ export async function activate(context: vscode.ExtensionContext) {
 	// Make builder names clickable in any terminal output
 	context.subscriptions.push(
 		vscode.window.registerTerminalLinkProvider(
-			new BuilderTerminalLinkProvider(connectionManager, terminalManager, outputChannel),
+			new BuilderTerminalLinkProvider(terminalManager),
 		),
 	);
 

packages/vscode/src/terminal-link-provider.ts

@@ -1,5 +1,4 @@
 import * as vscode from 'vscode';
-import type { ConnectionManager } from './connection-manager.js';
 import type { TerminalManager } from './terminal-manager.js';
 
 // Matches Codev builder role names like `builder-spir-153`, `builder-bugfix-42`.
@@ -14,11 +13,7 @@ interface BuilderLink extends vscode.TerminalLink {
  * Clicking opens (or focuses) that builder's terminal.
  */
 export class BuilderTerminalLinkProvider implements vscode.TerminalLinkProvider<BuilderLink> {
-  constructor(
-    private connectionManager: ConnectionManager,
-    private terminalManager: TerminalManager,
-    private outputChannel: vscode.OutputChannel,
-  ) {}
+  constructor(private terminalManager: TerminalManager) {}
 
   provideTerminalLinks(context: vscode.TerminalLinkContext): BuilderLink[] {
     const links: BuilderLink[] = [];
@@ -36,29 +31,6 @@ export class BuilderTerminalLinkProvider implements vscode.TerminalLinkProvider<
   }
 
   async handleTerminalLink(link: BuilderLink): Promise<void> {
-    const client = this.connectionManager.getClient();
-    const workspacePath = this.connectionManager.getWorkspacePath();
-    if (!client || !workspacePath) {
-      vscode.window.showErrorMessage('Codev: Not connected to Tower');
-      return;
-    }
-
-    try {
-      const state = await client.getWorkspaceState(workspacePath);
-      const builder = state?.builders?.find(b => b.name === link.roleId || b.id === link.roleId);
-      if (!builder?.terminalId) {
-        vscode.window.showWarningMessage(`Codev: No active terminal for ${link.roleId}`);
-        return;
-      }
-      await this.terminalManager.openBuilder(builder.terminalId, builder.id, `Codev: ${builder.name}`);
-    } catch (err) {
-      this.log('ERROR', `Failed to open builder ${link.roleId}: ${(err as Error).message}`);
-      vscode.window.showErrorMessage(`Codev: Failed to open ${link.roleId}`);
-    }
-  }
-
-  private log(level: string, message: string): void {
-    const timestamp = new Date().toISOString();
-    this.outputChannel.appendLine(`[${timestamp}] [BuilderLinks] [${level}] ${message}`);
+    await this.terminalManager.openBuilderByRoleOrId(link.roleId);
   }
 }

packages/vscode/src/terminal-manager.ts

@@ -59,6 +59,32 @@ export class TerminalManager {
     await this.openTerminal(terminalId, 'builder', label, key);
   }
 
+  /**
+   * Resolve a builder by `roleId` or `id` via Tower workspace state, then
+   * open its terminal. Used by the sidebar tree views, terminal link
+   * provider, and command palette so the lookup logic lives in one place.
+   */
+  async openBuilderByRoleOrId(roleOrId: string): Promise<void> {
+    const client = this.connectionManager.getClient();
+    const workspacePath = this.connectionManager.getWorkspacePath();
+    if (!client || !workspacePath) {
+      vscode.window.showErrorMessage('Codev: Not connected to Tower');
+      return;
+    }
+    try {
+      const state = await client.getWorkspaceState(workspacePath);
+      const builder = state?.builders?.find((b) => b.name === roleOrId || b.id === roleOrId);
+      if (!builder?.terminalId) {
+        vscode.window.showWarningMessage(`Codev: No active terminal for ${roleOrId}`);
+        return;
+      }
+      await this.openBuilder(builder.terminalId, builder.id, `Codev: ${builder.name}`);
+    } catch (err) {
+      this.log('ERROR', `Failed to open builder ${roleOrId}: ${(err as Error).message}`);
+      vscode.window.showErrorMessage(`Codev: Failed to open ${roleOrId}`);
+    }
+  }
+
   /**
    * Open a shell terminal.
    */

packages/vscode/src/test/terminal-link-provider.test.ts

@@ -1,43 +1,29 @@
 import * as assert from 'assert';
 import * as vscode from 'vscode';
 import { BuilderTerminalLinkProvider } from '../terminal-link-provider.js';
-import type { ConnectionManager } from '../connection-manager.js';
 import type { TerminalManager } from '../terminal-manager.js';
 
-const fakeOutputChannel = (): vscode.OutputChannel => ({
-	name: 'test',
-	append: () => {},
-	appendLine: () => {},
-	clear: () => {},
-	show: () => {},
-	hide: () => {},
-	dispose: () => {},
-	replace: () => {},
-});
-
 function fakeContext(line: string): vscode.TerminalLinkContext {
 	return { line, terminal: undefined as unknown as vscode.Terminal };
 }
 
+// A TerminalManager that throws if any method is called from render.
+const guardedTerminalManager = {
+	openBuilderByRoleOrId: () => { throw new Error('openBuilderByRoleOrId called from provideTerminalLinks'); },
+	openBuilder: () => { throw new Error('openBuilder called from provideTerminalLinks'); },
+} as unknown as TerminalManager;
+
 suite('BuilderTerminalLinkProvider.provideTerminalLinks', () => {
 	test('matches a single builder role name', () => {
-		const provider = new BuilderTerminalLinkProvider(
-			{} as ConnectionManager,
-			{} as TerminalManager,
-			fakeOutputChannel(),
-		);
+		const provider = new BuilderTerminalLinkProvider(guardedTerminalManager);
 		const links = provider.provideTerminalLinks(fakeContext('starting builder-spir-153 now'));
 		assert.strictEqual(links.length, 1);
 		assert.strictEqual(links[0].roleId, 'builder-spir-153');
 		assert.strictEqual(links[0].length, 'builder-spir-153'.length);
 	});
 
 	test('matches multiple builder role names on one line', () => {
-		const provider = new BuilderTerminalLinkProvider(
-			{} as ConnectionManager,
-			{} as TerminalManager,
-			fakeOutputChannel(),
-		);
+		const provider = new BuilderTerminalLinkProvider(guardedTerminalManager);
 		const links = provider.provideTerminalLinks(
 			fakeContext('builders: builder-spir-153, builder-bugfix-42, builder-air-7'),
 		);
@@ -48,36 +34,23 @@ suite('BuilderTerminalLinkProvider.provideTerminalLinks', () => {
 	});
 
 	test('does not match non-builder text', () => {
-		const provider = new BuilderTerminalLinkProvider(
-			{} as ConnectionManager,
-			{} as TerminalManager,
-			fakeOutputChannel(),
-		);
+		const provider = new BuilderTerminalLinkProvider(guardedTerminalManager);
 		assert.strictEqual(provider.provideTerminalLinks(fakeContext('no role here')).length, 0);
 		assert.strictEqual(provider.provideTerminalLinks(fakeContext('foo-bar-baz')).length, 0);
 	});
 
-	test('does not call into ConnectionManager during render', () => {
+	test('does not call into TerminalManager during render', () => {
 		// Regression pin for PR #682 review #2: provideTerminalLinks fires per
 		// terminal paint, so it must stay pure. Tower lookup belongs in
-		// handleTerminalLink (click handler).
-		const guarded = {
-			getClient: () => { throw new Error('getClient called from provideTerminalLinks'); },
-			getWorkspacePath: () => { throw new Error('getWorkspacePath called from provideTerminalLinks'); },
-		} as unknown as ConnectionManager;
-		const provider = new BuilderTerminalLinkProvider(guarded, {} as TerminalManager, fakeOutputChannel());
-
+		// handleTerminalLink (click handler) via openBuilderByRoleOrId.
+		const provider = new BuilderTerminalLinkProvider(guardedTerminalManager);
 		assert.doesNotThrow(() =>
 			provider.provideTerminalLinks(fakeContext('builder-spir-1 builder-spir-2 builder-spir-3')),
 		);
 	});
 
 	test('regex re-resets between calls (statefulness check)', () => {
-		const provider = new BuilderTerminalLinkProvider(
-			{} as ConnectionManager,
-			{} as TerminalManager,
-			fakeOutputChannel(),
-		);
+		const provider = new BuilderTerminalLinkProvider(guardedTerminalManager);
 		// Module-level regex with /g flag carries lastIndex; provider must reset.
 		const a = provider.provideTerminalLinks(fakeContext('builder-spir-1'));
 		const b = provider.provideTerminalLinks(fakeContext('builder-spir-2'));

packages/vscode/src/views/builders.ts

@@ -25,6 +25,11 @@ export class BuildersProvider implements vscode.TreeDataProvider<vscode.TreeItem
       item.iconPath = b.blocked
         ? new vscode.ThemeIcon('debug-pause', new vscode.ThemeColor('testing.iconFailed'))
         : new vscode.ThemeIcon('play', new vscode.ThemeColor('testing.iconPassed'));
+      item.command = {
+        command: 'codev.openBuilderById',
+        title: 'Open Builder Terminal',
+        arguments: [b.id],
+      };
       return item;
     });
   }

packages/vscode/src/views/needs-attention.ts

@@ -27,6 +27,11 @@ export class NeedsAttentionProvider implements vscode.TreeDataProvider<vscode.Tr
       const item = new vscode.TreeItem(`#${b.issueId ?? b.id} — blocked on ${b.blocked} ${waitTime}`);
       item.iconPath = new vscode.ThemeIcon('bell', new vscode.ThemeColor('notificationsWarningIcon.foreground'));
       item.contextValue = 'blocked-builder';
+      item.command = {
+        command: 'codev.openBuilderById',
+        title: 'Open Builder Terminal',
+        arguments: [b.id],
+      };
       items.push(item);
     }