Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for queries that don't have a scheme #31

Open
Fitzsimmons opened this issue Feb 13, 2017 · 1 comment
Open

Support for queries that don't have a scheme #31

Fitzsimmons opened this issue Feb 13, 2017 · 1 comment

Comments

@Fitzsimmons
Copy link

Fitzsimmons commented Feb 13, 2017

When implementing cmdipass, I noticed that if you submit a query that doesn't have a scheme (e.g. http://), you get the entire database back. I assume that getting the entire database will be fixed by #30. But the official implementation of KeePassHttp doesn't seem to care about the protocol.

That is, if I have a database with an entry called test-token and I run cmdipass get test-token against KeePassHttp, I'll just get back the one entry. If I run that against MacPassHTTP, I'll get the whole database.

If the user alters their command to add a protocol, e.g. cmdipass get http://test-token the command will execute as expected (only getting one entry) against both implementations. However, since the protocol doesn't seem to be strictly necessary by the reference implementation, I'm opening this Issue since it probably shouldn't be required by MacPassHTTP either.

@Fitzsimmons Fitzsimmons changed the title Support for queries that don't have a protocol prefix Support for queries that don't have a scheme Feb 13, 2017
@Fitzsimmons
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant