Correct legacy import assert syntax
#66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(node:2417313) V8: file:///home/ckie/git/svelte-persistent-store/rollup.config.mjs:6 'assert' is deprecated in import statements and support will be removed in a future version; use 'with' instead
|
I will have to pull some stats on the Node version usage. If the quantity of users that use an old version of Node that don't the support the new syntax is very small, the change can be done |
|
SGTM! Just to clarify since I realize it was ambiguous in the original text, the old syntax is unsupported in recent node versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(node:2417313) V8: file:///home/ckie/git/svelte-persistent-store/rollup.config.mjs:6 'assert' is deprecated in import statements and support will be removed in a future version; use 'with' instead
Allows use of my usual Node.js v24, previously only worked when i tested on v20.