Skip to content

Commit 0717693

Browse files
authored
Merge pull request #41 from MacFJA/fix-missing-default-issue-38
Missing default values on highlight option
2 parents 68283a3 + 88821fe commit 0717693

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111
- Documentation on paginated responses
1212
- Throw custom exception is client is missing
1313

14+
### Fixed
15+
16+
- Missing default values on highlight option ([Issue#38])
17+
1418
### Changed
1519

1620
- Rework paginated responses
@@ -216,6 +220,7 @@ First version
216220
[Issue#12]: https://github.com/MacFJA/php-redisearch/issues/12
217221
[Issue#16]: https://github.com/MacFJA/php-redisearch/issues/16
218222
[Issue#26]: https://github.com/MacFJA/php-redisearch/issues/26
223+
[Issue#38]: https://github.com/MacFJA/php-redisearch/issues/38
219224
[Issue#39]: https://github.com/MacFJA/php-redisearch/issues/39
220225
[PR#1]: https://github.com/MacFJA/php-redisearch/pull/1
221226
[PR#3]: https://github.com/MacFJA/php-redisearch/pull/3

src/Redis/Command/Search.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public function setSummarize(?array $fields = null, ?int $fragmentCount = null,
161161
*
162162
* @return $this
163163
*/
164-
public function setHighlight(?array $fields, ?string $openTag, ?string $closeTag): self
164+
public function setHighlight(?array $fields, ?string $openTag = null, ?string $closeTag = null): self
165165
{
166166
$this->options['highlight']
167167
->setDataOfOption('type', true)

0 commit comments

Comments
 (0)