Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uvfits should have information about when it was created. #117

Open
d3v-null opened this issue Oct 18, 2022 · 3 comments
Open

uvfits should have information about when it was created. #117

d3v-null opened this issue Oct 18, 2022 · 3 comments
Milestone

Comments

@d3v-null
Copy link
Collaborator

it is not possible to determine the date that a uvfits file was created without metadata from the filesystem. This metadata can be lost when transferring between filesystems like when uploading a file to acacia. It would be good to store the date a uvfits file was created in the header somewhere.

AIPS117 has a DATE-MAP field for this purpose. The marlu::context::History object could be extended to take an Option<Epoch> (defaults to SystemTime::now()) to facilitate this.

@cjordan
Copy link
Collaborator

cjordan commented Oct 18, 2022

I don't think that History should be extended; the uvfits writer should simply write the new key with the current time.

@d3v-null
Copy link
Collaborator Author

I see the History object as being useful for reading rows out of the HISTORY table in ms, but you're right that we don't need to break the existing api for this feature.

@cjordan
Copy link
Collaborator

cjordan commented Oct 19, 2022

Ah, I see. Currently Marlu doesn't do any vis reading, but if/when it does, I think it'd be sufficient to have a trait method that grabs the creation time. Probably also trait methods for getting the "command", "application" etc. seeing as History is currently just a little container only for writing.

@d3v-null d3v-null added this to the v1.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants