Update repository adresses in get_BGC.sh for ocean master branch

[sbrus89]

Just a very minor fix. These are up to date in the develop branches, but they still refer to the ACME-Climate repo in the master branch. Thanks to our colleagues in A-1 for catching this!

[sbrus89]

For reference, this is where the issue is...

From master:

MPAS-Model/src/core_ocean/get_BGC.sh

Lines 10 to 14 in 51d5624

	## Available protocols for acquiring BGC source code
	BGC_GIT_HTTP_ADDRESS=https://github.com/ACME-Climate/Ocean-BGC.git
	BGC_GIT_SSH_ADDRESS=git@github.com:ACME-Climate/Ocean-BGC.git
	BGC_SVN_ADDRESS=https://github.com/ACME-Climate/Ocean-BGC-src/tags
	BGC_WEB_ADDRESS=https://github.com/ACME-Climate/Ocean-BGC-src/archive

From ocean/develop:

MPAS-Model/src/core_ocean/get_BGC.sh

Lines 9 to 13 in 7cb3d6e

	## Available protocols for acquiring BGC source code
	BGC_GIT_HTTP_ADDRESS=https://github.com/E3SM-Project/Ocean-BGC.git
	BGC_GIT_SSH_ADDRESS=git@github.com:E3SM-Project/Ocean-BGC.git
	BGC_SVN_ADDRESS=https://github.com/E3SM-Project/Ocean-BGC-src/tags
	BGC_WEB_ADDRESS=https://github.com/E3SM-Project/Ocean-BGC-src/archive

[xylar]

This is presumably just a matter of waiting until ocean/develop gets merged into master, unless this is a more urgent problem?

I believe the old URL works even though it's not up-to-date.

[mark-petersen]

The old ACME-Climate address forwards to the new E3SM-Project address. For example,
git clone git@github.com:ACME-Climate/Ocean-BGC.git
works, and
https://github.com/ACME-Climate/Ocean-BGC.git
forwards to E3SM-Project on a web browser. So there is no action to be taken. As @xylar
said, it will update on master for the next release, but there is no harm for now. @sbrus89, does that resolve the issue for you?

[sbrus89]

I think the issue in this specific case may have been with the svn links. For example: https://github.com/E3SM-Project/Ocean-BGC-src/archive no longer exists.

This is definitely not urgent. I just thought I'd document it.

[maltrud]

to follow up on what @sbrus89 noted, i think this is a case where a collaborator wanted to check out master and the build fails. should they be pointed to ocean/develop instead? in any case, it seems bad that master fails.

[mark-petersen]

I see now. The problem is not the ACME-Climate versus E3SM-Project. That always forwards. The problem is that these lines in both branches:

From master:

MPAS-Model/src/core_ocean/get_BGC.sh

Lines 3 to 5 in 51d5624

	## BGC Tag for build
	#BGC_TAG=fa3d49a
	BGC_TAG=9c31e70

From ocean/develop:

MPAS-Model/src/core_ocean/get_BGC.sh

Lines 3 to 5 in 7cb3d6e

	## BGC Tag for build
	BGC_TAG=5588636

point to hashes, not tags. Therefore this line doesn't work:

MPAS-Model/src/core_ocean/get_BGC.sh

Line 76 in 7cb3d6e

wget ${BGC_WEB_ADDRESS}/${BGC_TAG}.zip &> /dev/null

See, this cvmix tag works. Click on it and it downloads:
https://github.com/CVMix/CVMix-src/archive/v0.95-beta.zip
But this corresponding bgc hash does not:
https://github.com/E3SM-Project/Ocean-BGC-src/archive/5588636.zip
Github makes downloadable zip files for tagged commits, but not just any commit.

The A-1 people must have noticed because their set-up led to that wget command, and our systems all use the git clone command. The same thing would happen on ocean/develop.

The solution is to make tags for 9c31e70 and 5588636 on the BGC repo, and change the BGC_TAG= line from a hash to these tags.