Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Mar 9, 2025

This allows us to use the same functionality in MPAS-Analysis and Polaris. It also brings in the bug fix from MPAS-Dev/MPAS-Tools#621 that implemented proper boundary conditions.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented Mar 9, 2025

This will need MPAS-Dev/MPAS-Tools#607, followed by a release of MPAS-Tools 1.0.0

@xylar
Copy link
Collaborator Author

xylar commented Apr 13, 2025

Now needs MPAS-Dev/MPAS-Tools#621 followed by release of MPAS-Tools 1.1.0

@xylar
Copy link
Collaborator Author

xylar commented Apr 13, 2025

Testing

Here are some results for a SORRMr3 run:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis_mpas_tools_bsf/20250125.GMPAS-JRA1p5-DIB-PISMF.TL319_SOwISC12to30E3r3.chrysalis/ocean/index.html#fris_bsf

I'm running into some seemingly unrelated hanging in the test suite that I'm trying to work out. Results will be here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis/use-mpas-tools-bsf/

Update: hanging has been addressed in #1086

@xylar
Copy link
Collaborator Author

xylar commented Apr 13, 2025

Some examples:

image

image

image

image

@xylar xylar mentioned this pull request Apr 13, 2025
1 task
@xylar xylar force-pushed the use-mpas-tools-bsf branch from 15d083f to e9d0bc6 Compare April 13, 2025 17:10
@xylar xylar self-assigned this Apr 13, 2025
@xylar xylar added the bug label Apr 13, 2025
@xylar xylar marked this pull request as ready for review April 13, 2025 20:24
@xylar xylar requested a review from irenavankova April 13, 2025 20:24
@xylar
Copy link
Collaborator Author

xylar commented Apr 13, 2025

@irenavankova, I tested out my MPAS-Tools workflow on your SORRME2 data that was giving us trouble before, so I'm pretty confident that things are working. But are you in a position to try out the branch on that data on Chicoma? The difficulty might be that our projects (climate and e3sm) have become read-only.

@irenavankova
Copy link
Collaborator

I will do that. The climate directory being read only is annoying but I think I can do all new stuff (new branch etc) on scratch, I just need to install there all from start.

@irenavankova
Copy link
Collaborator

I ran it from Chicoma on my files and it looks good - similar to yours. There is this contour line on the all Antarctic plot that seems to be intersecting the continent, but I think that is just resolution of the plot and that the contour runs essentially around the continent, so all around Antarctica there is the light blue color (not light yellow), would you agree?

@xylar
Copy link
Collaborator Author

xylar commented Apr 14, 2025

There is this contour line on the all Antarctic plot that seems to be intersecting the continent, but I think that is just resolution of the plot and that the contour runs essentially around the continent, so all around Antarctica there is the light blue color (not light yellow), would you agree?

Yeah, it's not too troubling to me if contours intersect the continent sometimes. I think it's maybe a problem of having a contour at zero and a boundary value that we're trying to make close to zero, and a consequence of interpolation artifacts. I looked at the BSF on the MPAS mesh in ParaView and it looked fine even when I made the plot limits quite tight -- the boudnary value is pretty much the same around the continent. This was with what I think is the same data you're using.

So as long as we're not seeing crazy differences ~ 4 Sv or more around the continent, I think we're okay.

@irenavankova
Copy link
Collaborator

ok, great! Yes, same data but possibly a different time interval.

Copy link
Collaborator

@irenavankova irenavankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on chicoma and looks good!

@xylar
Copy link
Collaborator Author

xylar commented Apr 14, 2025

Thanks so much, @irenavankova !

@xylar xylar merged commit f7bb979 into MPAS-Dev:develop Apr 14, 2025
5 of 10 checks passed
@irenavankova
Copy link
Collaborator

Also the great news is that with all these bsf fixes, the FRIS circulation looks as it should, at least the broad pattern of inflows and outflows.

@xylar xylar deleted the use-mpas-tools-bsf branch April 14, 2025 23:25
@xylar
Copy link
Collaborator Author

xylar commented Apr 14, 2025

Also the great news is that with all these bsf fixes, the FRIS circulation looks as it should, at least the broad pattern of inflows and outflows.

that's really great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants