-
Notifications
You must be signed in to change notification settings - Fork 53
Switch to using barotropic streamfunction from mpas_tools
#1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will need MPAS-Dev/MPAS-Tools#607, followed by a release of MPAS-Tools 1.0.0 |
|
Now needs MPAS-Dev/MPAS-Tools#621 followed by release of MPAS-Tools 1.1.0 |
TestingHere are some results for a SORRMr3 run: I'm running into some seemingly unrelated hanging in the test suite that I'm trying to work out. Results will be here: Update: hanging has been addressed in #1086 |
15d083f to
e9d0bc6
Compare
|
@irenavankova, I tested out my MPAS-Tools workflow on your SORRME2 data that was giving us trouble before, so I'm pretty confident that things are working. But are you in a position to try out the branch on that data on Chicoma? The difficulty might be that our projects (climate and e3sm) have become read-only. |
|
I will do that. The climate directory being read only is annoying but I think I can do all new stuff (new branch etc) on scratch, I just need to install there all from start. |
|
I ran it from Chicoma on my files and it looks good - similar to yours. There is this contour line on the all Antarctic plot that seems to be intersecting the continent, but I think that is just resolution of the plot and that the contour runs essentially around the continent, so all around Antarctica there is the light blue color (not light yellow), would you agree? |
Yeah, it's not too troubling to me if contours intersect the continent sometimes. I think it's maybe a problem of having a contour at zero and a boundary value that we're trying to make close to zero, and a consequence of interpolation artifacts. I looked at the BSF on the MPAS mesh in ParaView and it looked fine even when I made the plot limits quite tight -- the boudnary value is pretty much the same around the continent. This was with what I think is the same data you're using. So as long as we're not seeing crazy differences ~ 4 Sv or more around the continent, I think we're okay. |
|
ok, great! Yes, same data but possibly a different time interval. |
irenavankova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on chicoma and looks good!
|
Thanks so much, @irenavankova ! |
|
Also the great news is that with all these bsf fixes, the FRIS circulation looks as it should, at least the broad pattern of inflows and outflows. |
that's really great to hear! |




This allows us to use the same functionality in MPAS-Analysis and Polaris. It also brings in the bug fix from MPAS-Dev/MPAS-Tools#621 that implemented proper boundary conditions.
Checklist
Testingcomment in the PR documents testing used to verify the changes