Adds Amazon AWS S3 support #268 #298
Open
+187
−93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for data stored in Amazon AWS S3 (buckets). For the moment, anywhere there is a
pn_dir
parameter in a function, the user can provide the S3 URI form which to find the desired input file. This should always begin with's3'
in order to work correctly. An example input would be:'s3://my-aws-bucket/'
.For example, I can read record
100
(both.dat
and.hea
) stored onmy-aws-bucket
like this:As mentioned in #73, I think it would be nice to transition away from WFDB's dependence on files and take an approach similar to this statement:
Where each helper function would be for a separate application (PhysioNet, AWS S3, Hadoop HDFS, etc.). This would probably be a significant change (I think
pn_dir
should be changed toremote_dir
at least) so something to look forward to inv4.0
??Fixes #268.