Skip to content

Replicated softmax#137

Open
Fede-Rausa wants to merge 11 commits intomasterfrom
replicated_softmax
Open

Replicated softmax#137
Fede-Rausa wants to merge 11 commits intomasterfrom
replicated_softmax

Conversation

@Fede-Rausa
Copy link
Collaborator

Adding Replicated Softmax (a restricted boltzmann machine for topic modeling) and Over Replicated Softmax (a deep version of the RSM) models to the octis topic models list.
Both can be currently evaluated only on classification, diversity and coherence metrics, but support locally a fast computation for the perplexity upper bound (that is supported also for the LDA in the gensim implementation, used by octis).

@silviatti
Copy link
Collaborator

Hi Federico, regarding the Python 3.8 error, it seems that some libraries have dropped support for python 3.8. I think it's time to deprecate it. Could you please remove Python 3.8 from python-publish.yml and any other related references?

Also, please add tests to ensure everything works as expected. I don't currently have time to verify the implementation manually, but adding tests will give us more confidence and serve as guardrails. You can follow the same patterns as in: https://github.com/MIND-Lab/OCTIS/blob/master/tests/test_octis.py and https://github.com/MIND-Lab/OCTIS/blob/master/tests/test_optimization.py.

Lastly, could you run a formatter (e.g., ruff) on the files you added?

Thanks,

Silvia

@silviatti silviatti self-requested a review November 24, 2025 00:20
Copy link
Collaborator Author

@Fede-Rausa Fede-Rausa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following Your advice, the old tests are passed.
Now the build process works for 3.9 and 3.10. I will supply soon the test functions for the RSM and oRSM, plus a better formatting. Thank You for the support.

Best regards,

Federico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants