GH-689: Amend scanner scheduling: Handling ScanError msg #691
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "This needs to be decided on GH-605. Look what mode you run and set it accordingly" | ||
| ), | ||
| msg, | ||
| ); |
There was a problem hiding this comment.
Bug: Incomplete Handler Causes Runtime Panic
The Handler<QualifiedPayablesMessage> implementation contains a todo!() macro. This causes a runtime panic when processing qualified payables messages, making the code path non-functional. It replaced a previously working ScanType::Payables.
| ScanType::Payables, | ||
| todo!( | ||
| "This needs to be decided on GH-605. Look what mode you run and set it accordingly" | ||
| ), |
There was a problem hiding this comment.
Bug: Outbound Payments Handler Contains Unresolved Todo
The OutboundPaymentsInstructions handler includes a todo!() macro, which will cause a runtime panic when processing outbound payments. This replaces a previously functional ScanType::Payables value, making this critical path non-functional. It looks like incomplete development work.
No description provided.