Skip to content

GH-602: Scanner system revamp #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jun 14, 2025
Merged

GH-602: Scanner system revamp #640

merged 56 commits into from
Jun 14, 2025

Conversation

@bertllll
Copy link
Contributor

@bertllll bertllll commented May 26, 2025

No description provided.

Bert added 30 commits April 6, 2025 22:17
GH-602: big bunch of changes
30185f3
GH-602: interim commit
66dd5c5
GH-602: four scans layout installed
06c9135
GH-602: mostly done but still some crumbs of work left
ad0ec6a
GH-602: interim commit
e1a0a59
GH-602: Recorder enriched by counter messages
f83ece2
GH-602: removed obfuscated and made right the formerly developed Stop…
b4b4cb1 
…Conditions
GH-602: removed obfuscated and made right the formerly developed Stop…
d5f0314 
…Conditions
GH-602: main part probably done
0968f41
Merge branch 'GH-602' of github.com:MASQ-Project/Node into GH-602
09cd7de
Merge branch 'GH-602' of github.com:MASQ-Project/Node into GH-602
c810ac8
Merge branch 'GH-602' of github.com:MASQ-Project/Node into GH-602
cbf8918
GH-602: more todos knocked off in accountant/mod.rs
69b4dd0
GH-602: deep dive into schedulers and the awarness of the schedule state
a12cd50
GH-602: save point before going into fully private scanner
513c9a7
GH-602: another save point, this time before turning the scanner into…
755a459 
… fully private object
GH-602: finally fully scanners as flexible parametrized generic objects
231ae8a
GH-602: todos placed (many) as understood as the whole design
330f127
GH-602: more cases covered...knocking off todos!() continues
f7377fd
GH-602: made a markup for upcoming steps
2c447b4
GH-602: made a markup for upcoming steps
f362cf8
GH-602: merge because diverged from remote
058a9d8
GH-602: Manual scanners prevented by the automation. Tested
493df7b
GH-602: More tests written; mainly constraining the manual scanning
bc311ab
GH-602: before trying to implement the ScanScheduleHintErrorResolver
f1169b6
GH-602: tests for pending payable scanner and its start scan error re…
fd216cf 
…solver are compiling
GH-602: all tests in scan_schedulers passing now
01d5091
GH-602: all tests in scan_schedulers passing now
36afdf3
GH-602: slowly fixing test in accountant/mod.rs
11b2e15
GH-602: merging because diverged with the remote
6dc99f5
utkarshg6
utkarshg6 reviewed May 30, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 30, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 30, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 30, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 30, 2025
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/mod.rs:3296

utkarshg6
utkarshg6 reviewed May 31, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 31, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 31, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 31, 2025
View reviewed changes
utkarshg6
utkarshg6 reviewed May 31, 2025
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phase 1 Review Finished. Good Luck!

Bert added 17 commits June 2, 2025 20:24
GH-602: first piece of the review finished
e5d2249
GH-602: addressing review continues...
1edcf82
GH-602: addressing review continues on and on...
b456136
GH-602: more things for the review...
2940b6b
GH-602: last 6 comments to address
cd0919c
GH-602: finished the big two tests covering the very start of the aut…
a271e8f 
…omatic process with pp scanner playing the first violin
GH-602: huge tests refactored
e09a1ef
GH-602: small functionalities made right and huge tests refactored
7deca27
Merge branch 'GH-602' of github.com:MASQ-Project/Node into GH-602
dd70a34
GH-602: prepared some fixes for early rescheduling
c548d18
GH-602: moved the scanner test utils
6f904e6
GH-602: counter message summary comment added
b369157
GH-602: probably finished the minimm of what can be submitted seriously
62eabf4
GH-602: removed commented out impl
5da5f47
GH-602: vast majority of the review is covered
2d3a16d
GH-602: refactoring in the biggeste tests - a la utkarsh
a5a17d1
GH-602: review two ends
4f07a22
@bertllll bertllll merged commit 009e9a2 into GH-598 Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utkarshg6 utkarshg6 utkarshg6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bertllll @utkarshg6