Gh v2 580b czarte and Dan #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CLI, update credentials handling, improve cache invalidation
…ring)>. Gonna do that.
dnwiebe
reviewed
May 14, 2025
dnwiebe
reviewed
May 14, 2025
| expected_introducer.metadata.last_update = result_introducer.metadata.last_update; | ||
| expected_introducer.metadata.country_undesirability = COUNTRY_UNDESIRABILITY_FACTOR; | ||
| expected_introducer.resign(); | ||
| let expected_introducer = NodeRecord::from(&agrs[0]); |
Collaborator
There was a problem hiding this comment.
I'm curious about why the last_update and country_undesirability changes to expected_introducer are no longer required to make it line up with result_introducer.
dnwiebe
reviewed
May 14, 2025
dnwiebe
reviewed
May 14, 2025
* added dbip_download github workflow * change to run every day on midnight for QA
* added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src
* added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch
* added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * fix generated-source branch name in condition * increse standard timeout milis const * manual trigger and debugging flags to runs * use variable to store git ls-remote command
* added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * fix generated-source branch name in condition * increse standard timeout milis const * manual trigger and debugging flags to runs * use variable to store git ls-remote command * add git fetch before checkout
* added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * fix generated-source branch name in condition * increse standard timeout milis const * manual trigger and debugging flags to runs * use variable to store git ls-remote command * add git fetch before checkout * fix workflow for nonexistent branch * fixing edgecases on nonexistent branch and no git changes * change neverssl to different web
dnwiebe
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.