Skip to content

GH-608: Redesign the PendingPayableScanner for sent_payable table (manily its DAO) #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
May 15, 2025
Merged

GH-608: Redesign the PendingPayableScanner for sent_payable table (manily its DAO) #617

merged 45 commits into from
May 15, 2025

Conversation

@utkarshg6
Copy link
Collaborator

@utkarshg6 utkarshg6 commented Apr 10, 2025

No description provided.

utkarshg6 added 30 commits April 10, 2025 13:04
@utkarshg6
GH-608: change the trait object to support SentPayables
df415c0
@utkarshg6
Revert "GH-608: change the trait object to support SentPayables"
f9f43be 
This reverts commit df415c0.
@utkarshg6
GH-608: introduce sent payable dao
17360c5
@utkarshg6
GH-608: add boilerplate code
b9c56ce
@utkarshg6
GH-608: implement insert_new_records
00dba17
@utkarshg6
GH-608: add test cases for the panic and error clause for the insert …
0779066 
…method
@utkarshg6
GH-608: introduce builder pattern for the Tx
954299a
@utkarshg6
GH-608: implement get_tx_identifiers
46ab105
@utkarshg6
GH-608: implement retrieve_pending_txs()
b5e11b5
@utkarshg6
GH-608: add more assertions for the retrieve_pending_txs() and implem…
df8e82a 
…ent Display for TxStatus
@utkarshg6
GH-608: rename time_t in fn names to unix_timestamp
df0ea02
@utkarshg6
GH-608: refactor sent_payable_dao.rs
5e198b2
@utkarshg6
GH-608: add stronger tests for insert_new_records()
8871b72
@utkarshg6
GH-608: retrieve txs conditionally
5b99e07
@utkarshg6
GH-608: change SQL to uppercase wherever necessary
64f14a0
@utkarshg6
GH-608: add RetrieveCondtion::ToRetry
41e6ea1
@utkarshg6
GH-608: add constant RETRY_THRESHOLD_SECS
fe1a66f
@utkarshg6
GH-608: implement display and from_str() for TxStatus
2201030
@utkarshg6
GH-608: implement retrieve_condition_display_works
2352699
@utkarshg6
GH-608: update the query for txs_to_retry and reorder trait functions
6d49640
@utkarshg6
GH-608: change SQL query for txs to retry
7b1fefe
@utkarshg6
GH-608: remove RETRY_THRESHOLD_SECS
a953c37
@utkarshg6
GH-608: remove retried column from the sent_payable table
918fc8f
@utkarshg6
GH-608: add ability to retrieve tx by hash
1514096
@utkarshg6
GH-608: add the ability to update statuses
9fade80
@utkarshg6
GH-608: add types for TxHash and RowID
b27620a
@utkarshg6
GH-608: add test for deleting records
c63c6f5
@utkarshg6
GH-608: add fn for deleting records
9d42af1
@utkarshg6
GH-608: add more TODOs
f4e92df
@utkarshg6
GH-608: error testing
5eab479
@utkarshg6 utkarshg6 linked an issue May 2, 2025 that may be closed by this pull request
Redesign the PendingPayableDAO for sent_payable table #608
Closed
bertllll
bertllll reviewed May 5, 2025
View reviewed changes
@utkarshg6 utkarshg6 merged commit 24eb855 into GH-598 May 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertllll bertllll bertllll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redesign the PendingPayableDAO for sent_payable table

3 participants

@utkarshg6 @bertllll