Fix for #136 (#137)

The type data passed to retrieve the background-operation-manager-registered command was incorrect, so commands were not returned correctly. As the commands were not returned correctly, clicking the button on the dashboard didn't wire up the click event for the command.

Resolved issue and added unit test to ensure that these sorts of commands are returned.

Author: CraigHawker

MFiles.VAF.Extensions.Tests/ConfigurableVaultApplicationBaseTests/ConfigurableVaultApplicationBaseTests.cs

@@ -7,6 +7,7 @@
 using MFiles.VAF.Configuration;
 using System.Collections.Generic;
 using MFiles.VAF.Extensions.Dashboards.Commands.CustomDomainCommandResolution;
+using System.Linq;
 
 namespace MFiles.VAF.Extensions.Tests
 {
@@ -24,6 +25,45 @@ public void GetCustomDomainCommandResolver_Default()
 			Assert.IsNotNull(resolver);
 			Assert.IsInstanceOfType(resolver, typeof(DefaultCustomDomainCommandResolver<object>));
 		}
+
+		[TestMethod]
+		public void TaskQueueBackgroundOperationsManager_ReturnsCommands()
+		{
+			var proxy = new ConfigurableVaultApplicationBaseProxy<object>();
+
+			var vaultMock = new Mock<Vault>();
+			vaultMock
+				.Setup(m => m.GetVaultServerAttachments())
+				.Returns(() =>
+				{
+					var attachments = new VaultServerAttachments();
+					attachments.Add(0, new VaultServerAttachment());
+					return attachments;
+				});
+			vaultMock.SetupGet(m => m.ApplicationTaskOperations).Returns(Mock.Of<VaultApplicationTaskOperations>());
+
+			// Create a background operation and set it up so the command should be returned.
+			proxy.TaskManager = new TaskManagerEx<object>
+			(
+				proxy,
+				"taskManager",
+				vaultMock.Object,
+				Mock.Of<IVaultTransactionRunner>()
+			);
+			var operation = proxy.TaskQueueBackgroundOperationManager.CreateBackgroundOperation("test", () => { });
+
+			// Ensure that the domain resolver returns the command.
+			var returnedCommands = proxy
+					.GetCustomDomainCommandResolver()?
+					.GetCustomDomainCommands()?
+					.ToList() ?? new List<VAF.Configuration.AdminConfigurations.CustomDomainCommand>();
+			Assert.IsTrue
+			(
+				returnedCommands?
+					.Contains(operation.DashboardRunCommand) ?? false
+			);
+
+		}
 	}
 
 	public class ConfigurableVaultApplicationBaseProxy<TSecureConfigurationType>
@@ -40,6 +80,15 @@ public class ConfigurableVaultApplicationBaseProxy<TSecureConfigurationType>
 			get => base.ConfigurationStorage;
 			set => base.ConfigurationStorage = value;
 		}
+		protected internal new TaskQueueBackgroundOperationManager<TSecureConfigurationType> TaskQueueBackgroundOperationManager
+		{
+			get { return base.TaskQueueBackgroundOperationManager; }
+		}
+		protected internal new TaskManagerEx<TSecureConfigurationType> TaskManager
+		{
+			get { return base.TaskManager; }
+			set { base.TaskManager = value; }
+		}
 	}
 	public class ConfigurableVaultApplicationBaseProxy
 		: ConfigurableVaultApplicationBaseProxy<object>

MFiles.VAF.Extensions/Dashboards/Commands/CustomDomainCommandResolution/AsynchronousOperationCustomDomainCommandResolver.cs

@@ -53,7 +53,7 @@ protected virtual IEnumerable<CustomDomainCommand> GetTaskQueueBackgroundOperati
 			// Get the background operations that have a run command.
 			// Note: this should be all of them.
 			foreach (var c in
-				GetType()
+				VaultApplication.GetType()
 				.GetPropertiesAndFieldsOfType<TaskQueueBackgroundOperationManager<TSecureConfiguration>>(VaultApplication)
 				.SelectMany(tqbom => tqbom.BackgroundOperations)
 				.AsEnumerable()