Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOA-053][Enhancement] RE-structure the ApiResponseModel to response data to Clients in ControllersLayer (also apply for UnitTests). #97

Open
LyQuocCuong opened this issue Aug 25, 2023 · 0 comments
Open

[SOA-053][Enhancement] RE-structure the ApiResponseModel to response data to Clients in ControllersLayer (also apply for UnitTests). #97

LyQuocCuong opened this issue Aug 25, 2023 · 0 comments
Assignees
@LyQuocCuong
Labels
[Level] Medium Level of Issues [Note] Lesson Lessons (code, bug, mistakes,..) [Note] New Somethings are NEW (Tech, Code, Lib,...) [Type] Enhancement Type of Issues
Milestone
[Stage03] Advance...

Comments

@LyQuocCuong
Copy link
Owner

=====BEFORE=====

1) Describe the current situation

  • We need a template for response from Controllers.

2) What are the ideas for it?

  • I am going to use ApiResponseModel to do it.

3) Is it mandatory/optional? What if I don't enhance?

=====AFTER=====

1) Describe the solutions

2) Pros and Cons of this solution

3) Are there any NEW (technical, code,...) ?

4) Is it challenging and difficult to do? Why?

5) Any other notes?
@LyQuocCuong LyQuocCuong added [Level] Medium Level of Issues [Note] Lesson Lessons (code, bug, mistakes,..) [Note] New Somethings are NEW (Tech, Code, Lib,...) [Type] Enhancement Type of Issues labels Aug 25, 2023
@LyQuocCuong LyQuocCuong self-assigned this Aug 25, 2023
@github-project-automation github-project-automation bot moved this to ⚫ Not Started in eShopOnlineApi Aug 25, 2023
@LyQuocCuong LyQuocCuong changed the title [SOA-053][Enhancement] RE-structure the ApiResponseModel to response data to Clients in ControllersLayer. [SOA-053][Enhancement] RE-structure the ApiResponseModel to response data to Clients in ControllersLayer (also apply for UnitTests). Aug 25, 2023
@LyQuocCuong LyQuocCuong mentioned this issue Aug 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LyQuocCuong LyQuocCuong

Labels
[Level] Medium Level of Issues [Note] Lesson Lessons (code, bug, mistakes,..) [Note] New Somethings are NEW (Tech, Code, Lib,...) [Type] Enhancement Type of Issues
Projects
eShopOnlineApi
Status: ⚫ Not Started
Milestone
[Stage03] Advance Features (2 Sprints)
Development

No branches or pull requests
1 participant
@LyQuocCuong