[Internal review] Scripts for 3309 issue #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetmanetsIrina
changed the title
VjKlepikov
requested changes
Jun 9, 2022
| runner.Step("Clean environment", common.preconditions) | ||
| runner.Step("Start SDL, HMI, connect Mobile, start Session", common.start) | ||
| runner.Step("Register App", common.registerApp) | ||
| runner.Step("PTU", common.policyTableUpdate, { common.pTUpdateFunc }) |
There was a problem hiding this comment.
I propose to remove the redundant step common.policyTableUpdate, common.pTUpdateFunc = nil
Seems policy is updated in preconditions
| --------------------------------------------------------------------------------------------------- | ||
| --Issue: https://github.com/smartdevicelink/sdl_core/issues/3309 | ||
| --------------------------------------------------------------------------------------------------- | ||
| -- Description: SDL resends the parameter from HMI to mobile app in case app version is greather then parameter version, |
There was a problem hiding this comment.
Suggested change
| -- Description: SDL resends the parameter from HMI to mobile app in case app version is greather then parameter version, | |
| -- Description: SDL resends the parameter from HMI to mobile app in case app version is greater then parameter version, |
| for subKey, subValue in pairs (value.params) do | ||
| if subValue.name == "shifted" then | ||
| -- shifted has since="6.0" in API | ||
| pTbl.policy_table.vehicle_data.schema_items[key].params[subKey].since = "7.0.0" |
There was a problem hiding this comment.
Should we use since = "7.0" instead of 7.0.0 according to common style in preloaded.pt
Comment on lines
41
to
47
| elseif key == #value.params then | ||
| common.cprint(35, "'shifted' was not found in preloaded file") | ||
| end | ||
| end | ||
| elseif key == #pTbl.policy_table.vehicle_data.schema_items then | ||
| common.cprint(35, parameter .. " was not found in preloaded file") | ||
| end |
There was a problem hiding this comment.
Seems it not working in case the parameter is absent in sdl_preloaded_pt.json
I propose to add a parameter in case not found
| mandatory = false, | ||
| minvalue = 0, | ||
| maxvalue = 100, | ||
| since = "5.0.0" |
There was a problem hiding this comment.
Suggested change
| since = "5.0.0" | |
| since = "5.0" |
| --------------------------------------------------------------------------------------------------- | ||
| --Issue: https://github.com/smartdevicelink/sdl_core/issues/3309 | ||
| --------------------------------------------------------------------------------------------------- | ||
| -- Description: SDL resends the parameter from HMI to mobile app in case app version is less then parameter version, |
There was a problem hiding this comment.
Please update the description according to the step
| end | ||
| return true | ||
| end) | ||
| m.getMobileSession():ExpectResponse(cid, { success = true, resultCode = "SUCCESS", unpack(vehicleDataRes) }) |
There was a problem hiding this comment.
Seems 'unpack' function is wrong for vehicleDataRes and return ""
test_sets/Defects/1921.txt
Outdated
| ./test_scripts/Defects/4_5/1921_Invalid_PT_after_cutting_unknow_values.lua | ||
| ./test_scripts/Defects/4_5/1921_Invalid_PT_after_cutting_unknow_values.lua | ||
| ./test_scripts/Defects/4_5/1921_Invalid_PT_after_cutting_unknow_values.lua | ||
| ./test_scripts/Defects/4_5/1921_Invalid_PT_after_cutting_unknow_values.lua |
| --------------------------------------------------------------------------------------------------- | ||
| --Issue: https://github.com/smartdevicelink/sdl_core/issues/3309 | ||
| --------------------------------------------------------------------------------------------------- | ||
| -- Description: SDL cuts off parameter from HMI response,notification if app has less version then parameter version |
There was a problem hiding this comment.
Suggested change
| -- Description: SDL cuts off parameter from HMI response,notification if app has less version then parameter version | |
| -- Description: SDL cuts off parameter from HMI response/notification if app has less version then parameter version |
|
@VjKlepikov, please find updates in 57ddca8 |
VjKlepikov
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check #FORDTCN-12021
This PR is ready for internal review.
Summary
Scripts to check cutting off parameters from HMI response/notification if app has less version then parameter version
ATF version
develop
Changelog
CLA