Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save stats for z=0 #202

Open
jtravs opened this issue Apr 20, 2021 · 3 comments
Open

Save stats for z=0 #202

jtravs opened this issue Apr 20, 2021 · 3 comments

Comments

@jtravs
Copy link
Contributor

jtravs commented Apr 20, 2021

Is there a reason why we don't save the statistics for z=0? This would be very useful. It would also be nice to save for z=L too.

@jtravs
Copy link
Contributor Author

jtravs commented Apr 20, 2021

I'm guessing it is due to the interpolation, which deals with the exact end cases. Maybe a solution would be to save statistics whenever we save the field, using the interpolated field. And otherwise at the natural grid points when not saving the field?

@chrisbrahms
Copy link
Collaborator

There's no intentional reason, no. It happens because the stepfun in the solver is only called the first time after the first step, at which point the "current" field is already propagated.

Maybe a solution would be to save statistics whenever we save the field, using the interpolated field. And otherwise at the natural grid points when not saving the field?

So you mean adding extra stats points, one for each time we save the field? I think this would work, yes.

@jtravs
Copy link
Contributor Author

jtravs commented Apr 20, 2021

OK, I'm testing a PR for this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants