Skip to content

Commit 3a1185c

Browse files
committed
Reverted the code here
This change was to get ride of the nested ternary operators. However it resulted in the failing tests. Something went wrong in the conversion. I'll have to look at it more closely.
1 parent 7a51be0 commit 3a1185c

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

source/TALib/Core/PatternRecognition.php

+7-18
Original file line numberDiff line numberDiff line change
@@ -1256,26 +1256,15 @@ public static function cdlEngulfing(int $startIdx, int $endIdx, array $inOpen, a
12561256
$i = $startIdx;
12571257
$outIdx = 0;
12581258
do {
1259-
if (
1260-
(
1261-
($inOpen[$i] < $inClose[$i] && $inOpen[$i - 1] > $inClose[$i - 1]) &&
1262-
(
1263-
($inClose[$i] >= $inOpen[$i - 1] && $inOpen[$i] <= $inClose[$i - 1]) ||
1264-
($inClose[$i] > $inOpen[$i - 1] && $inOpen[$i] < $inClose[$i - 1])
1265-
)
1266-
) || (
1267-
($inOpen[$i] > $inClose[$i] && $inOpen[$i - 1] < $inClose[$i - 1]) &&
1268-
(
1269-
($inOpen[$i] >= $inClose[$i - 1] && $inClose[$i] <= $inOpen[$i - 1]) ||
1270-
($inOpen[$i] > $inClose[$i - 1] && $inClose[$i] < $inOpen[$i - 1])
1271-
)
1259+
if ((($inClose[$i] >= $inOpen[$i] ? 1 : -1) == 1 && ($inClose[$i - 1] >= $inOpen[$i - 1] ? 1 : -1) == -1 &&
1260+
$inClose[$i] > $inOpen[$i - 1] && $inOpen[$i] < $inClose[$i - 1]
1261+
)
1262+
||
1263+
(($inClose[$i] >= $inOpen[$i] ? 1 : -1) == -1 && ($inClose[$i - 1] >= $inOpen[$i - 1] ? 1 : -1) == 1 &&
1264+
$inOpen[$i] > $inClose[$i - 1] && $inClose[$i] < $inOpen[$i - 1]
12721265
)
12731266
) {
1274-
if (($inOpen[$i] != $inClose[$i - 1]) && ($inClose[$i] != $inOpen[$i - 1])) {
1275-
$outInteger[$outIdx++] = $inClose[$i] > $inOpen[$i] ? 100 : -100;
1276-
} else {
1277-
$outInteger[$outIdx++] = $inClose[$i] > $inOpen[$i] ? 80 : -80;
1278-
}
1267+
$outInteger[$outIdx++] = ($inClose[$i] >= $inOpen[$i] ? 1 : -1) * 100;
12791268
} else {
12801269
$outInteger[$outIdx++] = 0;
12811270
}

0 commit comments

Comments
 (0)